Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find rmm before cuco #4011

Merged
merged 2 commits into from
Nov 18, 2023
Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 17, 2023

RAPIDS currently relies on copies of CCCL headers bundled into rmm. This dependency is centralized by virtue of rmm installing these into the package and everything else finding those installed packages. To do this, however, rmm must be loaded first so that the libcudacxx install location is patched into CMake's search paths. cugraph also uses cuco, which requires libcudacxx but does not bundle its own, so rmm must be found first so that cuco can find libcudacxx where rmm installed it.

@vyasr vyasr added bug Something isn't working non-breaking Non-breaking change labels Nov 17, 2023
@vyasr vyasr self-assigned this Nov 17, 2023
@vyasr vyasr requested a review from a team as a code owner November 17, 2023 22:27
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is probably the problem. I am a little upset I didn't think of this earlier. I checked the order of CPM packages, but I didn't consider that RMM's libcudacxx is put into a different path and thus needs to be handled first. 😢

@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 5d43f14 into rapidsai:branch-23.12 Nov 18, 2023
74 checks passed
@vyasr vyasr deleted the fix/find_package_order branch November 18, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants