-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily disable the deletion of the dask dataframe #3814
Temporarily disable the deletion of the dask dataframe #3814
Conversation
…m cudf edge lists
/ok to test |
@@ -337,7 +334,7 @@ def __from_edgelist( | |||
) | |||
for w, edata in ddf.items() | |||
} | |||
del ddf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this deletion come after the computation below is done anyway? If you are building graph from ddf
, then you cannot release the keys of ddf
until delayed_tasks_d
is finished computing/persisting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure why the keys were deleted before delayed_tasks_d
computes. My PR essentially removed that deletion and it worked. I am not sure if doing it after delayed_tasks_d
computes will make a difference but let me try.
/ok to test |
/ok to test |
/ok to test |
Looks like this PR still failed:
|
/ok to test |
/ok to test |
Removing |
/merge |
temporarily disable the deletion of the dask dataframe