Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate upstream models to cugraph-pyg #3763

Merged
merged 14 commits into from
Sep 6, 2023
Merged

Migrate upstream models to cugraph-pyg #3763

merged 14 commits into from
Sep 6, 2023

Conversation

tingyu66
Copy link
Member

@tingyu66 tingyu66 commented Aug 2, 2023 •
edited
Loading

This PR migrates SAGEConv and RGCNConv to cugraph-pyg, in preparation for removing these models from upstream.
pylibcugraphops now becomes a dependency of cugraph-pyg.

@tingyu66 tingyu66 requested review from a team as code owners August 2, 2023 23:18
@tingyu66 tingyu66 marked this pull request as draft August 2, 2023 23:18
@tingyu66 tingyu66 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 3, 2023
@tingyu66 tingyu66 self-assigned this Aug 3, 2023
@tingyu66 tingyu66 added this to the 23.10 milestone Aug 3, 2023
@tingyu66 tingyu66 marked this pull request as ready for review August 4, 2023 13:49
alexbarghi-nv
alexbarghi-nv approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexbarghi-nv
Copy link
Member

@tingyu66 it looks like you still need an ops review.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 31, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@tingyu66
Copy link
Member Author

/ok to test

@tingyu66
Copy link
Member Author

/ok to test

ajschmidt8
ajschmidt8 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@tingyu66
Copy link
Member Author

tingyu66 commented Sep 6, 2023

/ok to test

@alexbarghi-nv
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 6b57f56 into rapidsai:branch-23.10 Sep 6, 2023
54 checks passed
@tingyu66 tingyu66 deleted the migrate_pyg_models branch September 6, 2023 18:50
rlratzel pushed a commit to rlratzel/cugraph that referenced this pull request Sep 8, 2023
@tingyu66 @rlratzel
Migrate upstream models to cugraph-pyg (rapidsai#3763)
a24341d 
This PR migrates SAGEConv and RGCNConv to cugraph-pyg, in preparation for removing these models from upstream.
`pylibcugraphops` now becomes a dependency of cugraph-pyg.

Authors:
  - Tingyu Wang (https://github.com/tingyu66)

Approvers:
  - Alex Barghi (https://github.com/alexbarghi-nv)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#3763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbarghi-nv alexbarghi-nv alexbarghi-nv approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees

@tingyu66 tingyu66

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
23.10
Development

Successfully merging this pull request may close these issues.
3 participants
@tingyu66 @alexbarghi-nv @ajschmidt8