Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test for checking is_symmetric is valid, update documentatio… #3559

Merged

Conversation

ChuckHastings
Copy link
Collaborator

Closes #3149

Seunghwa updated the graph creation in #3533. This PR adds a unit test which validates that enabling do_expensive_check does verify that the input is symmetric.

@ChuckHastings ChuckHastings self-assigned this May 15, 2023
@ChuckHastings ChuckHastings added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 15, 2023
@ChuckHastings ChuckHastings added this to the 23.06 milestone May 15, 2023
@ChuckHastings ChuckHastings marked this pull request as ready for review May 15, 2023 19:56
@ChuckHastings ChuckHastings requested a review from a team as a code owner May 15, 2023 19:56
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit dd7aa5e into rapidsai:branch-23.06 May 16, 2023
@ChuckHastings ChuckHastings deleted the validate_is_symmetric branch September 27, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is_symmetric is still ignored in pylibcugraph when do_expensive_check is enabled
3 participants