Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dgl APIs for v1.1.0 #3546

Merged
merged 2 commits into from
May 8, 2023
Merged

Update dgl APIs for v1.1.0 #3546

merged 2 commits into from
May 8, 2023

Conversation

tingyu66
Copy link
Member

@tingyu66 tingyu66 commented May 8, 2023 •
edited
Loading

DGL v1.1.0 introduced a breaking change that renames adj_sparse to adj_tensors, causing the following error in our CI:

nn/test_gatconv.py::test_gatconv_equality[False-None-1-False] - AttributeError: 'DGLGraph' object has no attribute 'adj_sparse'
nn/test_gatconv.py::test_gatconv_equality[False-None-1-True] - AttributeError: 'DGLBlock' object has no attribute 'adj_sparse'

This PR updates the usage in cugraph-dgl tests.

CC: @alexbarghi-nv

@tingyu66 tingyu66 requested review from a team as code owners May 8, 2023 15:23
@tingyu66 tingyu66 self-assigned this May 8, 2023
@tingyu66 tingyu66 added non-breaking Non-breaking change bug Something isn't working labels May 8, 2023
alexbarghi-nv
alexbarghi-nv approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ajschmidt8
Copy link
Member

Looks like conda isn't able to find dgl>=1.1: https://github.com/rapidsai/cugraph/actions/runs/4916791547/jobs/8783112845?pr=3546#step:7:1988

@tingyu66
Copy link
Member Author

tingyu66 commented May 8, 2023

Looks like conda isn't able to find dgl>=1.1: https://github.com/rapidsai/cugraph/actions/runs/4916791547/jobs/8783112845?pr=3546#step:7:1988

Thanks for catching that. DGL started adding cuda suffix to the version (1.1.0.cu118) and conda treats it as a pre-release. Just updated the version requirements to satisfy the ordering.

@alexbarghi-nv
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 2c32a4d into rapidsai:branch-23.06 May 8, 2023
@tingyu66 tingyu66 deleted the fix-dgl-error branch May 8, 2023 22:09
@tingyu66 tingyu66 mentioned this pull request May 25, 2023
Merged
rapids-bot bot pushed a commit that referenced this pull request May 26, 2023
@tingyu66
correct dgl version in cugraph-dgl conda recipe (#3612)
451e4e6 
Bump up dgl version in `cugraph-dgl` conda recipe, which is overlooked in PR #3546.

Authors:
  - Tingyu Wang (https://github.com/tingyu66)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)
  - Ray Douglass (https://github.com/raydouglass)
  - Vibhu Jawa (https://github.com/VibhuJawa)

URL: #3612
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbarghi-nv alexbarghi-nv alexbarghi-nv approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees

@tingyu66 tingyu66

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tingyu66 @ajschmidt8 @alexbarghi-nv