Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update select_random_vertices to sample from a given distributed set or from (0, V] #3455

Merged
merged 22 commits into from
Apr 21, 2023
Merged

Update select_random_vertices to sample from a given distributed set or from (0, V] #3455

merged 22 commits into from
Apr 21, 2023

Conversation

naimnv
Copy link
Contributor

@naimnv naimnv commented Apr 6, 2023 •
edited
Loading

Update select_random_vertices to select from a given distributed set
Remove randomly_select_destinations and randomly_select and use select_random_vertices

@naimnv naimnv requested a review from a team as a code owner April 6, 2023 23:30
@naimnv naimnv marked this pull request as draft April 6, 2023 23:31
@naimnv naimnv marked this pull request as ready for review April 6, 2023 23:44
@naimnv naimnv changed the title Upate select_random_vertices to selete from a given set of vertices Upate select_random_vertices to select from a given set of vertices Apr 6, 2023
@naimnv naimnv marked this pull request as draft April 6, 2023 23:46
@naimnv naimnv changed the title Upate select_random_vertices to select from a given set of vertices [WIP][skip-ci] Upate select_random_vertices to select from a given set of vertices Apr 7, 2023
@seunghwak seunghwak assigned naimnv and unassigned ChuckHastings and seunghwak Apr 7, 2023
@seunghwak
Copy link
Contributor

@naimnv you can assign me and Chuck as "Reviewers" when this PR is ready for review. "Assignees" is for the ones who are responsible for updating this PR; i.e. you :-)

@naimnv
Copy link
Contributor Author

naimnv commented Apr 7, 2023

I must had been reading Reviewers but clicked on settings of Assignees :)

@naimnv naimnv added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 15, 2023
@naimnv naimnv marked this pull request as ready for review April 15, 2023 01:33
@naimnv naimnv changed the title [WIP][skip-ci] Upate select_random_vertices to select from a given set of vertices Sample a subset from a given distributed set, instead of (0, V] Apr 15, 2023
@naimnv naimnv changed the title Sample a subset from a given distributed set, instead of (0, V] Sample a subset from a given distributed set, instead of sampling from (0, V] Apr 15, 2023
@naimnv naimnv requested review from a team as code owners April 15, 2023 02:11
@naimnv naimnv changed the title Update select_random_vertices to sample a subset from a given distributed set or from (0, V] Update select_random_vertices to sample from a given distributed set or from (0, V] Apr 16, 2023
@naimnv naimnv added this to the 23.06 milestone Apr 16, 2023
@ajschmidt8 ajschmidt8 removed the request for review from a team April 17, 2023 15:53
@ajschmidt8
Copy link
Member

Removing ops-codeowners from the required reviews since it doesn't seem there are any file changes that we're responsible for. Feel free to add us back if necessary.

@naimnv
Copy link
Contributor Author

naimnv commented Apr 17, 2023 •
edited
Loading

@ajschmidt8 IIRC, I didn't add ops-codeowners, I supposed it's read from settings/config?

seunghwak
seunghwak reviewed Apr 17, 2023
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/rapidsai/cugraph/blob/branch-23.06/cpp/tests/utilities/thrust_wrapper.hpp#L50

is no longer necessary with this update. Better delete as well.

cpp/src/structure/select_random_vertices_impl.hpp Show resolved Hide resolved
cpp/src/structure/select_random_vertices_impl.hpp Outdated Show resolved Hide resolved
cpp/src/structure/select_random_vertices_impl.hpp Show resolved Hide resolved
cpp/src/structure/select_random_vertices_impl.hpp Outdated Show resolved Hide resolved
cpp/src/structure/select_random_vertices_impl.hpp Outdated Show resolved Hide resolved
cpp/src/structure/select_random_vertices_impl.hpp Outdated Show resolved Hide resolved
cpp/src/structure/select_random_vertices_impl.hpp Outdated Show resolved Hide resolved
cpp/src/structure/select_random_vertices_impl.hpp Outdated Show resolved Hide resolved
cpp/src/structure/select_random_vertices_impl.hpp Outdated Show resolved Hide resolved
cpp/tests/CMakeLists.txt Outdated Show resolved Hide resolved
seunghwak
seunghwak reviewed Apr 17, 2023
View reviewed changes
cpp/tests/structure/mg_select_random_vertices_test.cpp Outdated Show resolved Hide resolved
cpp/tests/structure/mg_select_random_vertices_test.cpp Outdated Show resolved Hide resolved
cpp/tests/structure/mg_select_random_vertices_test.cpp Outdated Show resolved Hide resolved
cpp/tests/structure/mg_select_random_vertices_test.cpp Outdated Show resolved Hide resolved
cpp/tests/structure/mg_select_random_vertices_test.cpp Outdated Show resolved Hide resolved
cpp/tests/structure/mg_select_random_vertices_test.cpp Outdated Show resolved Hide resolved
cpp/tests/structure/mg_select_random_vertices_test.cpp Outdated Show resolved Hide resolved
cpp/tests/structure/mg_select_random_vertices_test.cpp Outdated Show resolved Hide resolved
cpp/tests/structure/mg_select_random_vertices_test.cpp Outdated Show resolved Hide resolved
cpp/tests/structure/mg_select_random_vertices_test.cpp Outdated Show resolved Hide resolved
ChuckHastings
ChuckHastings reviewed Apr 17, 2023
View reviewed changes
cpp/include/cugraph/graph_functions.hpp Show resolved Hide resolved
cpp/include/cugraph/graph_functions.hpp Outdated Show resolved Hide resolved
cpp/include/cugraph/partition_manager.hpp Outdated Show resolved Hide resolved
cpp/src/structure/select_random_vertices_impl.hpp Outdated Show resolved Hide resolved
cpp/src/structure/select_random_vertices_impl.hpp Outdated Show resolved Hide resolved
cpp/src/structure/select_random_vertices_impl.hpp Outdated Show resolved Hide resolved
cpp/include/cugraph/partition_manager.hpp Outdated Show resolved Hide resolved
cpp/src/structure/select_random_vertices_impl.hpp Outdated Show resolved Hide resolved
@alexbarghi-nv alexbarghi-nv removed the request for review from a team April 18, 2023 17:34
seunghwak
seunghwak reviewed Apr 20, 2023
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I believe we don't need

randomly_select()
(https://github.com/rapidsai/cugraph/blob/branch-23.06/cpp/tests/utilities/thrust_wrapper.cu#L210)

anymore with this PR.

cpp/src/structure/select_random_vertices_impl.hpp Show resolved Hide resolved
cpp/src/structure/select_random_vertices_impl.hpp Outdated Show resolved Hide resolved
@naimnv
Copy link
Contributor Author

naimnv commented Apr 20, 2023

And I believe we don't need

randomly_select() (https://github.com/rapidsai/cugraph/blob/branch-23.06/cpp/tests/utilities/thrust_wrapper.cu#L210)

anymore with this PR.

Removed.

@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit 7308a8f into rapidsai:branch-23.06 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunghwak seunghwak seunghwak approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

Assignees

@naimnv naimnv

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
23.06
Development

Successfully merging this pull request may close these issues.
4 participants
@naimnv @seunghwak @ajschmidt8 @ChuckHastings