Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update conv layers in cugraph-dgl for pylibcugraphops 23.04 #3360

Merged
merged 12 commits into from
Apr 5, 2023

Conversation

tingyu66
Copy link
Member

@tingyu66 tingyu66 commented Mar 23, 2023

Update cugraph-ops models to use pylibcugraphops 23.04. This PR also supersedes #3264

CC: @MatthiasKohl

@tingyu66 tingyu66 requested a review from a team as a code owner March 23, 2023 20:41
@tingyu66 tingyu66 marked this pull request as draft March 23, 2023 20:41
@tingyu66 tingyu66 added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Mar 23, 2023
@tingyu66 tingyu66 self-assigned this Mar 23, 2023
@tingyu66 tingyu66 marked this pull request as ready for review March 27, 2023 20:27
@tingyu66 tingyu66 requested a review from a team as a code owner March 27, 2023 20:27
@tingyu66 tingyu66 requested a review from VibhuJawa March 28, 2023 01:39
@@ -117,7 +117,7 @@ if [[ "${RAPIDS_CUDA_VERSION}" == "11.8.0" ]]; then
--channel "${PYTHON_CHANNEL}" \
--channel pytorch \
--channel pytorch-nightly \
--channel dglteam/label/cu117 \
--channel dglteam/label/cu118 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, just saw that that they have cu118 builds here: https://anaconda.org/dglteam/dgl

Surprisingly it is missing on getting started page: https://www.dgl.ai/pages/start.html

Copy link
Contributor

@MatthiasKohl MatthiasKohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from my side. as discussed live, with 23.06, hopefully, we can get rid of the pad_offsets thing altogether, using new structures

Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@BradReesWork BradReesWork added this to the 23.04 milestone Mar 30, 2023
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlratzel
Copy link
Contributor

rlratzel commented Apr 5, 2023

/merge

@rapids-bot rapids-bot bot merged commit a4c97b5 into rapidsai:branch-23.04 Apr 5, 2023
@tingyu66 tingyu66 deleted the update-cugraphops-2304 branch April 6, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants