Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New PyG End-to-End Examples #3326

Merged
merged 73 commits into from
Apr 4, 2023
Merged

New PyG End-to-End Examples #3326

merged 73 commits into from
Apr 4, 2023

Conversation

alexbarghi-nv
Copy link
Member

@alexbarghi-nv alexbarghi-nv commented Mar 10, 2023 •
edited by BradReesWork
Loading

  • Adds new examples for cugraph-pyg.
  • Removes outdated examples.
  • Moves MG scripts to top-level directory.
  • Makes the input to _get_vertex_groups_from_sample a tensor instead of Series
  • Adds is_sorted arg to _get_vertex_groups_from_sample to skip sorting if tensor already sorted
  • Some fixes to CuGraphStore for running multi-GPU workflows

Merge after #3288 - merged
Merge after #3289 - merged
Merge after #3382 - merged

Closes #3316
Closes #3226
Closes #3072

alexbarghi-nv and others added 21 commits February 16, 2023 18:07
@alexbarghi-nv
pull in files, add skip for all pyg tests
9a1ef56
@alexbarghi-nv
skip tests on 11.8
f0ec571
@alexbarghi-nv
Merge branch 'branch-23.04' into update-ci-for-pyg
656f5d3
@alexbarghi-nv
update branch
05919f1
@alexbarghi-nv
Merge branch 'branch-23.04' into update-pyg-tests
6da5291
@alexbarghi-nv
update skip reason
04e83c5
@alexbarghi-nv
Merge branch 'update-ci-for-pyg' of https://github.com/alexbarghi-nv/…
3bae1ef 
…cugraph into update-ci-for-pyg
@alexbarghi-nv
skip mg test on sg
4510729
@alexbarghi-nv
update backend script
cd02854
@alexbarghi-nv
remove backend
cdc7733
@alexbarghi-nv
separate the pyg tests, use different env
2b36c64
@alexbarghi-nv
minor formatting fix
447fdd3
@alexbarghi-nv
Merge branch 'branch-23.04' into update-ci-for-pyg
610d482
@alexbarghi-nv
update pytorch req to >=2.0
4637af9
@alexbarghi-nv
fix pytorch only to version number
dd36a95
@alexbarghi-nv
add comments to ci file
18d650f
@alexbarghi-nv
skip testing pyg on arm
8f4e577
@alexbarghi-nv
skip tests on arm
cfa6331
@alexbarghi-nv
Merge branch 'branch-23.04' into update-ci-for-pyg
731483c
@alexbarghi-nv
add working sg, partially working mg
5437888
@alexbarghi-nv
remove rmm log
d9554eb
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@alexbarghi-nv alexbarghi-nv added DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function breaking Breaking change labels Mar 10, 2023
@alexbarghi-nv alexbarghi-nv self-assigned this Mar 10, 2023
@alexbarghi-nv alexbarghi-nv changed the title New PyG End-to-End Examples [skip-ci] New PyG End-to-End Examples Mar 10, 2023
@rlratzel rlratzel removed the DO NOT MERGE Hold off on merging; see PR for details label Mar 10, 2023
VibhuJawa
VibhuJawa approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rlratzel
rlratzel approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some minor feedback and questions which need not hold up approval (can be addressed pre or post commit).

mg_utils/default-config.sh Outdated Show resolved Hide resolved
python/cugraph-pyg/cugraph_pyg/examples/graph_sage_mg.py


def stop_cugraph_dask_client():
from cugraph.dask.comms import comms as Comms
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why this and other modules are imported inline, especially since some like this show up in multiple places.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importing cugraph will start a CUDA context prior to setting up rmm to use the right GPU

python/cugraph-pyg/cugraph_pyg/examples/start_dask.sh Outdated Show resolved Hide resolved
@BradReesWork BradReesWork added this to the 23.04 milestone Mar 30, 2023
@alexbarghi-nv alexbarghi-nv added the Blocked Cannot progress due to external reasons label Apr 3, 2023
@BradReesWork BradReesWork removed the Blocked Cannot progress due to external reasons label Apr 3, 2023
@alexbarghi-nv
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit c61ef05 into rapidsai:branch-23.04 Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VibhuJawa VibhuJawa VibhuJawa approved these changes

@rlratzel rlratzel rlratzel approved these changes

@BradReesWork BradReesWork Awaiting requested review from BradReesWork

Assignees

@alexbarghi-nv alexbarghi-nv

Labels
breaking Breaking change improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
23.04
4 participants
@alexbarghi-nv @rlratzel @VibhuJawa @BradReesWork