Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to rapidsai/rmm#1221 which moves allocator callbacks #3300

Merged

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Feb 24, 2023

The allocator callbacks now live in their own submodules (so that RMM does not, for example, import pytorch unless required) and so must be explicitly imported.

The allocator callbacks now live in their own submodules (so that RMM
does not, for example, import pytorch unless required) and so must be
explicitly imported.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@wence- wence- marked this pull request as ready for review February 28, 2023 09:47
@wence- wence- requested review from a team as code owners February 28, 2023 09:47
@alexbarghi-nv alexbarghi-nv self-assigned this Mar 27, 2023
@alexbarghi-nv alexbarghi-nv added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 27, 2023
@alexbarghi-nv alexbarghi-nv added this to the 23.04 milestone Mar 27, 2023
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wence- wence- force-pushed the wence/fix/rmm-allocator-move branch from e51ea0c to 8fcd695 Compare April 5, 2023 08:33
@wence-
Copy link
Contributor Author

wence- commented Apr 5, 2023

Fixed merge conflicts, so hopefully this is now good.

@wence-
Copy link
Contributor Author

wence- commented Apr 5, 2023

/merge

1 similar comment
@rlratzel
Copy link
Contributor

rlratzel commented Apr 5, 2023

/merge

@rapids-bot rapids-bot bot merged commit 0225e92 into rapidsai:branch-23.04 Apr 5, 2023
@wence- wence- deleted the wence/fix/rmm-allocator-move branch April 5, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants