-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to rapidsai/rmm#1221 which moves allocator callbacks #3300
Merged
rapids-bot
merged 4 commits into
rapidsai:branch-23.04
from
wence-:wence/fix/rmm-allocator-move
Apr 5, 2023
Merged
Adapt to rapidsai/rmm#1221 which moves allocator callbacks #3300
rapids-bot
merged 4 commits into
rapidsai:branch-23.04
from
wence-:wence/fix/rmm-allocator-move
Apr 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The allocator callbacks now live in their own submodules (so that RMM does not, for example, import pytorch unless required) and so must be explicitly imported.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
alexbarghi-nv
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Mar 27, 2023
alexbarghi-nv
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
rlratzel
approved these changes
Apr 4, 2023
wence-
force-pushed
the
wence/fix/rmm-allocator-move
branch
from
April 5, 2023 08:33
e51ea0c
to
8fcd695
Compare
Fixed merge conflicts, so hopefully this is now good. |
/merge |
1 similar comment
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The allocator callbacks now live in their own submodules (so that RMM does not, for example, import pytorch unless required) and so must be explicitly imported.