Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Bug Fixes to DGL Dataloader #3247

Merged
merged 23 commits into from
Mar 28, 2023
Merged

[REVIEW] Bug Fixes to DGL Dataloader #3247

merged 23 commits into from
Mar 28, 2023

Conversation

VibhuJawa
Copy link
Member

@VibhuJawa VibhuJawa commented Feb 7, 2023 •
edited
Loading

Todo:

  • Support adding file along with directories
  • Test for block size, src,dst lengths for nodes for homogeneous and heterogeneous graphs

@VibhuJawa VibhuJawa changed the title [WIP] Bug Fixes to Bulk Sampler [WIP] Bug Fixes to DGL Dataloader Feb 7, 2023
@VibhuJawa VibhuJawa self-assigned this Feb 7, 2023
@VibhuJawa VibhuJawa added this to the 23.04 milestone Feb 7, 2023
@VibhuJawa VibhuJawa added non-breaking Non-breaking change Fix bug Something isn't working labels Feb 7, 2023
@VibhuJawa
Merge branch 'branch-23.04' into bulk_sampling_bug_fix
b48bb59
@VibhuJawa
bulk_sampling_bug_fix
a805416
@VibhuJawa
Make torch/dgl runtime dependencies
a5f6775
@VibhuJawa
Make torch/dgl runtime dependencies
6e7e7be
@VibhuJawa
cleanup sampling_helpers.py
980d111
@VibhuJawa
cleanup sampling_helpers.py
a8fd5bf
@VibhuJawa
Add option of adding files as well as directory
f2619fb
@VibhuJawa
Merge branch 'branch-23.04' into bulk_sampling_bug_fix
f3de0e0
@VibhuJawa
Fix local tests
f299786
@VibhuJawa
Merge branch 'branch-23.04' into bulk_sampling_bug_fix
59483f2
@VibhuJawa
Based on latest bulk-sampler results
1ba4ea5
@VibhuJawa
Merge branch 'branch-23.04' into bulk_sampling_bug_fix
7a93581
@VibhuJawa
Merge branch 'branch-23.04' into bulk_sampling_bug_fix
ed5efe4
@VibhuJawa
Merge branch 'bulk_sampling_bug_fix' of https://github.com/VibhuJawa/…
d85205c 
…cugraph into bulk_sampling_bug_fix
@VibhuJawa
Add dataloader tests
b6641e6
@VibhuJawa
Style fix
aa26077
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@VibhuJawa VibhuJawa changed the title [WIP] Bug Fixes to DGL Dataloader [REVIEW] Bug Fixes to DGL Dataloader Mar 24, 2023
@VibhuJawa VibhuJawa marked this pull request as ready for review March 24, 2023 21:38
@VibhuJawa VibhuJawa requested a review from a team as a code owner March 24, 2023 21:38
alexbarghi-nv
alexbarghi-nv approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@VibhuJawa VibhuJawa requested a review from rlratzel March 27, 2023 16:37
@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit e91bf8a into rapidsai:branch-23.04 Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbarghi-nv alexbarghi-nv alexbarghi-nv approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

@rlratzel rlratzel Awaiting requested review from rlratzel

Assignees

@VibhuJawa VibhuJawa

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
23.04
Development

Successfully merging this pull request may close these issues.
4 participants
@VibhuJawa @BradReesWork @alexbarghi-nv @kingmesal