-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs build job #3157
Add docs build job #3157
Conversation
9230a15
to
ec65d20
Compare
Codecov ReportBase: 55.30% // Head: 55.30% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #3157 +/- ##
=============================================
Coverage 55.30% 55.30%
=============================================
Files 148 148
Lines 9573 9573
=============================================
Hits 5294 5294
Misses 4279 4279 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ec65d20
to
f37f827
Compare
f37f827
to
a1ebed9
Compare
df859bd
to
bd9eb12
Compare
@AyodeAwe there is a merge conflict |
@VibhuJawa how should this style check failure be handled? The error showed up after we imported your patch:
https://github.com/rapidsai/cugraph/actions/runs/4247522209/jobs/7385666170 cc: @ajschmidt8 |
This line I think we had a bad merge which erased it. Anyways, add it and you should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that @VibhuJawa looked over some of the non-docs related changes to cugraph-dgl files, so I'm assuming those are supposed to be in this PR.
Yes. Good call out, @rlratzel. There were some import issues that required a patch from Vibhu which we included. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rlratzel , Yup those changes allow building |
/merge |
The PR adds a
docs_build
process to the PR and Build workflows for this repository. The generated docs are synced to s3 for only the build workflows.