Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEMPORARILY allows python and notebook tests that return exit code 139 to pass. #3132

Merged

Conversation

rlratzel
Copy link
Contributor

This PR TEMPORARILY allows python and notebook tests that return exit code 139 to pass.

This allows CI to pass for PRs that are failing with 139 on exit, due to a bug that exists that results in a Seg Fault on exit, which is blocking all other PRs. An example can be seen here.

This will be reverted ASAP!

Note that failing pytest tests result in return codes of something other than 139, so PRs that fail tests for reasons other than a Seg Fault will still be blocked from merging. This also does not apply to C++ tests.

…s CI to pass for PRs that are failing with 139 on exit, due to a bug that exists which is blocking all other PRs. This will be reverted ASAP!
@rlratzel rlratzel added the non-breaking Non-breaking change label Jan 11, 2023
@rlratzel rlratzel added this to the 23.02 milestone Jan 11, 2023
@rlratzel rlratzel self-assigned this Jan 11, 2023
@rlratzel rlratzel requested a review from a team as a code owner January 11, 2023 22:08
@rlratzel rlratzel added the bug Something isn't working label Jan 11, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 57.60% // Head: 57.60% // No change to project coverage 👍

Coverage data is based on head (b12e9e2) compared to base (5bf1f44).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-23.02    #3132   +/-   ##
=============================================
  Coverage         57.60%   57.60%           
=============================================
  Files               147      147           
  Lines              9227     9227           
=============================================
  Hits               5315     5315           
  Misses             3912     3912           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rlratzel
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit a0b7bd9 into rapidsai:branch-23.02 Jan 12, 2023
@rlratzel rlratzel deleted the branch-23.02-tmp_unblock_ci branch September 28, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants