build.sh switch to use RAPIDS magic value
#3127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapids-cmake 23.02 is deprecating the magic value of `ALL` since it doesn't cleanly map to the cmake magic value of `all`. Instead we use `RAPIDS` which better represents the architectures we are building for.
robertmaynard
changed the title
RAPIDS magic valueRAPIDS magic value
7 tasks
BradReesWork
requested review from
vyasr,
rlratzel and
BradReesWork
and removed request for
vyasr and
rlratzel
BradReesWork
added
improvement
BradReesWork
approved these changes
Jan 10, 2023
rlratzel
approved these changes
Jan 12, 2023
|
rerun tests |
1 similar comment
|
rerun tests |
…s-cmake-magic-value
Codecov ReportBase: 57.60% // Head: 55.15% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #3127 +/- ##
================================================
- Coverage 57.60% 55.15% -2.45%
================================================
Files 147 147
Lines 9227 9375 +148
================================================
- Hits 5315 5171 -144
- Misses 3912 4204 +292
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/merge |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rapids-cmake 23.02 is deprecating the magic value of
ALLsince it doesn't cleanly map to the cmake magic value ofall. Instead we useRAPIDSwhich better represents the architectures we are building for.