Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build pip wheels alongside conda CI #3096

Merged
merged 82 commits into from
Feb 6, 2023
Merged

Build pip wheels alongside conda CI #3096

merged 82 commits into from
Feb 6, 2023

Conversation

sevagh
Copy link
Contributor

@sevagh sevagh commented Dec 30, 2022

This PR adds pip wheel CI to the Conda CI, instead of having them work separately.

@sevagh sevagh requested a review from a team as a code owner December 30, 2022 17:19
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022

Codecov Report

Base: 56.26% // Head: 56.26% // No change to project coverage 👍

Coverage data is based on head (0e62fca) compared to base (a78e4d4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-23.02    #3096   +/-   ##
=============================================
  Coverage         56.26%   56.26%           
=============================================
  Files               153      153           
  Lines              9658     9658           
=============================================
  Hits               5434     5434           
  Misses             4224     4224           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

.github/workflows/pr.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor comments then need smoke tests.

.github/workflows/build.yaml Outdated Show resolved Hide resolved
ci/release/update-version.sh Show resolved Hide resolved
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 5, 2023
.github/workflows/build.yaml Outdated Show resolved Hide resolved
@BradReesWork BradReesWork added this to the 23.02 milestone Jan 13, 2023
@vyasr vyasr requested a review from a team as a code owner February 2, 2023 20:37
@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 7ad71e7 into rapidsai:branch-23.02 Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants