Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C++ Bugs in Graph Creation with Edge Properties #3093

Merged

Conversation

alexbarghi-nv
Copy link
Member

There are currently two bugs in graph creation with edge properties, which this PR resolves.

Closes https://github.com/rapidsai/graph_dl/issues/106

@alexbarghi-nv alexbarghi-nv requested a review from a team as a code owner December 28, 2022 16:10
@alexbarghi-nv alexbarghi-nv self-assigned this Dec 28, 2022
@alexbarghi-nv alexbarghi-nv added Fix non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Dec 28, 2022
@alexbarghi-nv alexbarghi-nv added this to the 23.02 milestone Dec 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2022

Codecov Report

Base: 57.60% // Head: 57.40% // Decreases project coverage by -0.19% ⚠️

Coverage data is based on head (098c234) compared to base (e40409d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02    #3093      +/-   ##
================================================
- Coverage         57.60%   57.40%   -0.20%     
================================================
  Files               147      147              
  Lines              9227     9227              
================================================
- Hits               5315     5297      -18     
- Misses             3912     3930      +18     
Impacted Files Coverage Δ
...ython/cugraph/cugraph/community/ktruss_subgraph.py 41.17% <0.00%> (-50.00%) ⬇️
...raph/structure/graph_implementation/simpleGraph.py 78.69% <0.00%> (-0.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

cpp/src/c_api/graph_mg.cpp Show resolved Hide resolved
cpp/src/structure/create_graph_from_edgelist_impl.cuh Outdated Show resolved Hide resolved
cpp/src/structure/create_graph_from_edgelist_impl.cuh Outdated Show resolved Hide resolved
cpp/src/structure/create_graph_from_edgelist_impl.cuh Outdated Show resolved Hide resolved
@alexbarghi-nv
Copy link
Member Author

I'll revert the changes to create_graph_from_edgelist_impl and leave that to you to fix in #2997

@alexbarghi-nv
Copy link
Member Author

@ChuckHastings I reverted create_graph_from_edgelist_impl, this should be good to go now.

@ChuckHastings
Copy link
Collaborator

/merge

@ChuckHastings
Copy link
Collaborator

rerun tests

@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit 324f370 into rapidsai:branch-23.02 Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants