Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for MG property graph #3090

Merged
merged 7 commits into from
Jan 12, 2023

Conversation

eriknw
Copy link
Contributor

@eriknw eriknw commented Dec 20, 2022

Small PR to fix MGPG tests.

Note that @galipremsagar fixed the equivalent tests for test_property_graph.py in #3036 by using s._constructor, which is pretty slick.

Also, start_dask_client returns a tuple of client and cluster now, so I updated the dask_client fixture so the cluster can be closed properly.

@eriknw eriknw requested a review from a team as a code owner December 20, 2022 01:54
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Base: 57.60% // Head: 57.60% // No change to project coverage 👍

Coverage data is based on head (957829c) compared to base (324f370).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-23.02    #3090   +/-   ##
=============================================
  Coverage         57.60%   57.60%           
=============================================
  Files               147      147           
  Lines              9227     9227           
=============================================
  Hits               5315     5315           
  Misses             3912     3912           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexbarghi-nv alexbarghi-nv added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Fix labels Dec 20, 2022
@alexbarghi-nv alexbarghi-nv added this to the 23.02 milestone Dec 20, 2022
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 5c240dd into rapidsai:branch-23.02 Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants