Sampling primitive performance optimization. #3061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seunghwak
added
2 - In Progress
improvement
naimnv
approved these changes
Dec 12, 2022
naimnv
approved these changes
Dec 12, 2022
seunghwak
changed the title
seunghwak
added
bug
Codecov ReportBase: 57.60% // Head: 57.60% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #3061 +/- ##
=============================================
Coverage 57.60% 57.60%
=============================================
Files 147 147
Lines 9227 9227
=============================================
Hits 5315 5315
Misses 3912 3912 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ChuckHastings
approved these changes
Jan 12, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve performance for 1 & 2 GPU test cases (there will be follow-up PRs for larger scale testing/performance improvements)
Bug fix for the single GPU & invalid_value = thrust::nullopt case.