Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in the C++ CSV file reader (used in C++ testing only). #3055

Merged
merged 17 commits into from
Jan 4, 2023

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Dec 7, 2022

Bug fix in the C++ CSV file reader (when checking the provided edge list is symmetric or not).

@seunghwak seunghwak added bug Something isn't working 5 - Merge After Dependencies non-breaking Non-breaking change labels Dec 7, 2022
@seunghwak seunghwak added this to the 23.02 milestone Dec 7, 2022
@seunghwak seunghwak self-assigned this Dec 7, 2022
@seunghwak seunghwak requested a review from a team as a code owner December 7, 2022 01:40
@seunghwak
Copy link
Contributor Author

@jnke2016 This should fix the bug you're facing. Let me know if this doesn't.

  if (symmetrized_srcs.size() != org_srcs.size()) {
    return false;
  }

https://github.com/rapidsai/cugraph/pull/3055/files#diff-a8d124288865f004d17ae433f23d7bdccb599e31216b95aceb1bdde92f27ebffR86-R89

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2023

Codecov Report

Base: 57.14% // Head: 57.14% // No change to project coverage 👍

Coverage data is based on head (052fbe1) compared to base (1cb20d1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-23.02    #3055   +/-   ##
=============================================
  Coverage         57.14%   57.14%           
=============================================
  Files               148      148           
  Lines              9302     9302           
=============================================
  Hits               5316     5316           
  Misses             3986     3986           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit dcbe63c into rapidsai:branch-23.02 Jan 4, 2023
@seunghwak seunghwak deleted the bug_directed_graph branch May 5, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants