Adds parameterized benchmarks for uniform_neighbor_sampling, updates benchmarks dir for future additions
#3048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re_params_product() function to PLC.
…2-initial_service_benchmarks
…est to use specific set of input param combinations.
…uniform_neighbor_sampling options
… parameter for with_replacement.
…2-initial_service_benchmarks
…2-initial_service_benchmarks
…fo(), added tests to verify new meta-data is correct.
… with the server, added tests which use/test the new builtin test extensions.
…s (via rapids-pytest-benchmark plugin) easier to read, changes to allow RemoteGraph to use either a server-side Graph or PropertyGraph.
…r LocalCUDACluster for MG service, re-wrote start list generation to work with both SG and MG, added server extension for generating start list, changed scale from 24 to 23 to prevent OOM, added separate function for creating MG graphs, added debug print to show result sizes, fixes to cugraph MG Graph for incorrect column names, added util to cugraph for starting and stopping dask client.
…2-initial_service_benchmarks
…2-initial_service_benchmarks
…chmarks for different libraries.
…ir to pytest-based to avoid name conflict.
… can be more easily shared, bug fix in benchmark extension testing util.
…params, removed funcs unused in each file.
…arkers to pytest.ini, added pythonpath and test paths to pytest.ini, gave benchmark files unique names so pytest can collect them across different bench dirs.
…ception handler for loading extensions, run server from a temp dir to avoid collisions with 'cugraph' namespace package in benchmarks dir.
…2-initial_benchmark_reorg
rlratzel
added
improvement
…, added markers for each batch size.
alexbarghi-nv
approved these changes
Dec 8, 2022
…2-initial_benchmark_reorg
Codecov ReportBase: 58.86% // Head: 58.50% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #3048 +/- ##
================================================
- Coverage 58.86% 58.50% -0.37%
================================================
Files 131 133 +2
Lines 7848 7895 +47
================================================
- Hits 4620 4619 -1
- Misses 3228 3276 +48
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
VibhuJawa
suggested changes
Dec 13, 2022
benchmarks/cugraph/pytest-based/bench_cugraph_uniform_neighbor_sample.py
Outdated
Show resolved
Hide resolved
benchmarks/cugraph/pytest-based/bench_cugraph_uniform_neighbor_sample.py
Outdated
Show resolved
Hide resolved
| graph_props = pylibcugraph.experimental.GraphProperties( | ||
| is_symmetric=False, is_multigraph=False) | ||
| st = time.time() | ||
| G = pylibcugraph.experimental.SGGraph( |
There was a problem hiding this comment.
Suggested change
| G = pylibcugraph.experimental.SGGraph( | |
| G = pylibcugraph.experimental.MGGraph( |
There was a problem hiding this comment.
I think this needs to stay SGGraph since we're not incorporating dask/MPI/etc. anywhere to distribute the data to separate MGGraphs.
VibhuJawa
reviewed
Dec 13, 2022
…2-initial_benchmark_reorg
|
rerun tests reason: PG test failures should be fixed from this merged PR. |
raydouglass
approved these changes
Dec 15, 2022
BradReesWork
approved these changes
Dec 15, 2022
|
from @BradReesWork offline: will address those when a PR for this branch is pushed next. |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3034
This PR updates the top-level
benchmarksdir to better organize benchmarks (and future benchmarks) based on package name. Additional parameterized benchmarks foruniform_neighbor_samplingwere added as well as re-usable fixtures and pytest param objects and utilities.Other updates include:
genFixteurParamsProductand refactored so only one copy is used for both cugraph and PLCThe "breaking" label is used because the
benchmarksdir re-org changes the location of existing benchmarks, which could break scripts that call them.