Use Vertex ID Offsets in CuGraphStorage #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, this only does SG version for rapidsai#2401. MG is still TODO. This also doesn't change anything user-facing (yet).
This includes a slow workaround for rapidsai/cudf#11550
…nto cgs-remote-wrappers
…to cgs-remote-wrappers
…to cgs-remote-sample
…to cgs-remote-sample
Co-authored-by: Vibhu Jawa <[email protected]>
|
@alexbarghi-nv , ready for second round of reviews ? |
|
Go ahead |
rlratzel
reviewed
Jan 4, 2023
VibhuJawa
reviewed
Jan 5, 2023
Co-authored-by: Rick Ratzel <[email protected]>
|
rerun tests |
1 similar comment
|
rerun tests |
rlratzel
approved these changes
Jan 12, 2023
|
@rlratzel I think this can be merged now |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users Vertex ID offsets in
CuGraphStore. Offers the option of using pre-computed offsets by settingrenumber_graph=False. Default behavior is to warn the user that it is computing offsets and save the original vertex ids in a new column. Ifrenumber_graph=True, there is no warning,renumber_vertices_by_type()is called, and the vertex ids are overwritten.Due to a bug in
MGPropertyGraph, if vertices are renumbered, edges must also be renumbered.Closes https://github.com/rapidsai/graph_dl/issues/95
Closes #3069
Includes fix for #3069
Merge after #3012