Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix cluster startup script #2977

Merged
merged 2 commits into from
Nov 30, 2022
Merged

[REVIEW] Fix cluster startup script #2977

merged 2 commits into from
Nov 30, 2022

Conversation

VibhuJawa
Copy link
Member

This PR fixes cluster startup script

@VibhuJawa VibhuJawa requested a review from a team as a code owner November 23, 2022 17:53
@VibhuJawa VibhuJawa added non-breaking Non-breaking change Fix bug Something isn't working labels Nov 23, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 59.61% // Head: 59.61% // No change to project coverage 👍

Coverage data is based on head (2db3983) compared to base (27fa711).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@              Coverage Diff              @@
##           branch-22.12    #2977   +/-   ##
=============================================
  Coverage         59.61%   59.61%           
=============================================
  Files               129      129           
  Lines              7656     7656           
=============================================
  Hits               4564     4564           
  Misses             3092     3092

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

alexbarghi-nv
alexbarghi-nv approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the options that work for me. Approved.

@alexbarghi-nv alexbarghi-nv added this to the 22.12 milestone Nov 28, 2022
@VibhuJawa VibhuJawa mentioned this pull request Nov 28, 2022
Merged
@BradReesWork
Copy link
Member

rerun tests

2 similar comments
@BradReesWork
Copy link
Member

rerun tests

@BradReesWork
Copy link
Member

rerun tests

rlratzel
rlratzel approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I actually had to make the same changes to a PR I haven't submitted yet.

@rlratzel
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 60f5e7b into rapidsai:branch-22.12 Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbarghi-nv alexbarghi-nv alexbarghi-nv approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

@rlratzel rlratzel rlratzel approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
22.12
Development

Successfully merging this pull request may close these issues.
5 participants
@VibhuJawa @codecov-commenter @BradReesWork @rlratzel @alexbarghi-nv