Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove all algorithms from cython.cu #2955

Merged
merged 1 commit into from
Nov 17, 2022
Merged

remove all algorithms from cython.cu #2955

merged 1 commit into from
Nov 17, 2022

Conversation

ChuckHastings
Copy link
Collaborator

@ChuckHastings ChuckHastings commented Nov 17, 2022 •
edited
Loading

Should unblock #2834

This removes all of the algorithms from cython.cu.

Closes #2498

Marked as breaking since we remove some old python bindings, they should no longer be used.

@ChuckHastings ChuckHastings requested review from a team as code owners November 17, 2022 19:01
@ChuckHastings ChuckHastings self-assigned this Nov 17, 2022
@ChuckHastings ChuckHastings added 3 - Ready for Review improvement Improvement / enhancement to an existing function breaking Breaking change labels Nov 17, 2022
@ChuckHastings ChuckHastings added this to the 22.12 milestone Nov 17, 2022
seunghwak
seunghwak approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this great effort!

And just a side question, we still need to perform shuffle and renumber through cython?

@ChuckHastings
Copy link
Collaborator Author

And just a side question, we still need to perform shuffle and renumber through cython?

Joseph is working on the python changes for that, they aren't merged yet.

jnke2016
jnke2016 approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@jnke2016 jnke2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e2a3468 into rapidsai:branch-22.12 Nov 17, 2022
@BradReesWork
Copy link
Member

@gpucibot merge

@ChuckHastings ChuckHastings deleted the remove_algorithms_from_cython_cu branch December 2, 2022 18:36
@ChuckHastings ChuckHastings mentioned this pull request Feb 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnke2016 jnke2016 jnke2016 approved these changes

@seunghwak seunghwak seunghwak approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

Assignees

@ChuckHastings ChuckHastings

Labels
breaking Breaking change improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
22.12
Development

Successfully merging this pull request may close these issues.

MNMG WCC - Remove from cython.cu
4 participants
@ChuckHastings @BradReesWork @seunghwak @jnke2016