Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement two_hop_neighbors C API #2915

Merged

Conversation

ChuckHastings
Copy link
Collaborator

Implements the two hop neighbors C API using the k_hop_nbrs algorithm.

This should unblock #2704

@ChuckHastings ChuckHastings requested review from a team as code owners November 10, 2022 16:25
@ChuckHastings ChuckHastings self-assigned this Nov 10, 2022
@ChuckHastings ChuckHastings added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 10, 2022
@ChuckHastings ChuckHastings added this to the 22.12 milestone Nov 10, 2022
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but should we better generalize this for k-hop neighbors (maybe not right now)?

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.12@7387fbc). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head cfdabcb differs from pull request most recent head 6bceb70. Consider uploading reports for the commit 6bceb70 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.12    #2915   +/-   ##
===============================================
  Coverage                ?   60.72%           
===============================================
  Files                   ?      122           
  Lines                   ?     6856           
  Branches                ?        0           
===============================================
  Hits                    ?     4163           
  Misses                  ?     2693           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChuckHastings
Copy link
Collaborator Author

Added #2918 to remind us to eventually expose the k-hop version of this.

@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4802b28 into rapidsai:branch-22.12 Nov 10, 2022
@ChuckHastings ChuckHastings deleted the k_hop_neighbors_implement_c_api branch September 27, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants