-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyG Monorepo Refactor #2905
PyG Monorepo Refactor #2905
Conversation
Currently, this only does SG version for rapidsai#2401. MG is still TODO. This also doesn't change anything user-facing (yet).
This includes a slow workaround for rapidsai/cudf#11550
…nto cgs-remote-wrappers
…to cgs-remote-wrappers
…to cgs-remote-sample
…to cgs-remote-sample
Co-authored-by: Vibhu Jawa <[email protected]>
Co-authored-by: Vibhu Jawa <[email protected]>
Co-authored-by: Vibhu Jawa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor cleanup requested on setup.py
, looks good otherwise. Thanks again for addressing the last reviews.
Co-authored-by: Vibhu Jawa <[email protected]>
Co-authored-by: Vibhu Jawa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the changes, LGTM
…to pyg-monorepo-refactor
…to pyg-monorepo-refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rerun tests |
@gpucibot merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a typo is causing at least one of the error messages in CI.
Co-authored-by: Rick Ratzel <[email protected]>
Moves the PyG extensions to their own package. Includes conda package configurations.
Due to PyG 2.2 not being released on conda yet, it is not a hard dependency. This will be resolved when PyG 2.2 is released with conda packages. Going forward, we should encourage PyG to make their nightly builds available on conda so this issue does not occur again.
Resolves https://github.com/rapidsai/graph_dl/issues/48
Resolves https://github.com/rapidsai/graph_dl/issues/93