Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyG Monorepo Refactor #2905

Merged
merged 127 commits into from
Nov 30, 2022

Conversation

alexbarghi-nv
Copy link
Member

@alexbarghi-nv alexbarghi-nv commented Nov 10, 2022

Moves the PyG extensions to their own package. Includes conda package configurations.

  • File structure
  • Enable CI
  • Example integration test
  • Double-check PyG dependency, conda channel

Due to PyG 2.2 not being released on conda yet, it is not a hard dependency. This will be resolved when PyG 2.2 is released with conda packages. Going forward, we should encourage PyG to make their nightly builds available on conda so this issue does not occur again.

Resolves https://github.com/rapidsai/graph_dl/issues/48
Resolves https://github.com/rapidsai/graph_dl/issues/93

eriknw and others added 30 commits August 9, 2022 16:13
Currently, this only does SG version for rapidsai#2401.  MG is still TODO.

This also doesn't change anything user-facing (yet).
Co-authored-by: Vibhu Jawa <[email protected]>
build.sh Outdated Show resolved Hide resolved
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor cleanup requested on setup.py, looks good otherwise. Thanks again for addressing the last reviews.

python/cugraph-pyg/pytest.ini Outdated Show resolved Hide resolved
python/cugraph-pyg/pytest.ini Outdated Show resolved Hide resolved
python/cugraph-pyg/setup.py Outdated Show resolved Hide resolved
python/cugraph-pyg/setup.py Outdated Show resolved Hide resolved
python/cugraph-pyg/pyproject.toml Outdated Show resolved Hide resolved
python/cugraph-pyg/setup.py Outdated Show resolved Hide resolved
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the changes, LGTM

Copy link
Contributor

@msadang msadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexbarghi-nv
Copy link
Member Author

rerun tests

@BradReesWork
Copy link
Member

@gpucibot merge

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a typo is causing at least one of the error messages in CI.

ci/test.sh Outdated Show resolved Hide resolved
Co-authored-by: Rick Ratzel <[email protected]>
@rapids-bot rapids-bot bot merged commit fb5298d into rapidsai:branch-22.12 Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants