Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uniform neighborhood sampling memory leak #2835

Merged
merged 4 commits into from
Oct 21, 2022
Merged

Fix uniform neighborhood sampling memory leak #2835

merged 4 commits into from
Oct 21, 2022

Conversation

ChuckHastings
Copy link
Collaborator

Fix memory leak in uniform neighborhood sampling. Earlier updates adjusted the results but didn't fix the free method.

Closes #2788

@ChuckHastings ChuckHastings requested a review from a team as a code owner October 21, 2022 00:24
@ChuckHastings ChuckHastings self-assigned this Oct 21, 2022
@ChuckHastings ChuckHastings added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Oct 21, 2022
@ChuckHastings ChuckHastings added this to the 22.12 milestone Oct 21, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.12@74ead42). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head d42d1a6 differs from pull request most recent head 7a6c1d5. Consider uploading reports for the commit 7a6c1d5 to get more accurate results

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-22.12    #2835   +/-   ##
===============================================
  Coverage                ?   60.40%           
===============================================
  Files                   ?      114           
  Lines                   ?     6551           
  Branches                ?        0           
===============================================
  Hits                    ?     3957           
  Misses                  ?     2594           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChuckHastings ChuckHastings requested a review from a team as a code owner October 21, 2022 20:28
rlratzel
rlratzel requested changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I approved too soon. Looks like flake8 found a bad variable in the print statement.

@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9fbc255 into rapidsai:branch-22.12 Oct 21, 2022
@ChuckHastings ChuckHastings deleted the bug_uniform_neighbor_sampling_leak branch December 2, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunghwak seunghwak seunghwak approved these changes

@rlratzel rlratzel rlratzel approved these changes

Assignees

@ChuckHastings ChuckHastings

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
22.12
Development

Successfully merging this pull request may close these issues.

[BUG] Memory leak in uniform_neighbor_sample
4 participants
@ChuckHastings @codecov-commenter @rlratzel @seunghwak