Define API for Betweenness Centrality #2823
Conversation
ChuckHastings
added
2 - In Progress
improvement
Codecov ReportBase: 60.48% // Head: 60.28% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #2823 +/- ##
================================================
- Coverage 60.48% 60.28% -0.20%
================================================
Files 111 111
Lines 6526 6526
================================================
- Hits 3947 3934 -13
- Misses 2579 2592 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cpp/include/cugraph/algorithms.hpp
Outdated
| * betweenness either by random sampling @p num_vertices as the seeds of the traversal, or | ||
| * by using the provided @p vertices as the seeds of the traversal. | ||
| * | ||
| * If both @p and @num_vertices are specified we will throw an error. |
There was a problem hiding this comment.
Should we better use std::optional<std::variant>>? Then, the code self documents the expected behavior and this comment is unnecessary.
cpp/include/cugraph/algorithms.hpp
Outdated
| * handles to various CUDA libraries) to run graph algorithms. | ||
| * @param graph_view Graph view object. | ||
| * @param num_vertices Optional, if specified, how many vertices to randomly select | ||
| * @param vertices Optional, if specified this provides the list of vertices to app |
There was a problem hiding this comment.
It seems like some texts after to app got deleted.
There was a problem hiding this comment.
Fixed missing text, cleaned up documentation based on using std::variant
cpp/include/cugraph/algorithms.hpp
Outdated
| * betweenness either by random sampling @p num_vertices as the seeds of the traversal, or | ||
| * by using the provided @p vertices as the seeds of the traversal. | ||
| * | ||
| * If both @p and @num_vertices are specified we will throw an error. |
There was a problem hiding this comment.
Should we better use std::optional<std::variant>>? Then, the code self documents the expected behavior and this comment is unnecessary.
There was a problem hiding this comment.
Didn't think of that. Updated in next push.
cpp/include/cugraph/algorithms.hpp
Outdated
| * handles to various CUDA libraries) to run graph algorithms. | ||
| * @param graph_view Graph view object. | ||
| * @param num_vertices Optional, if specified, how many vertices to randomly select | ||
| * @param vertices Optional, if specified this provides the list of vertices to app |
There was a problem hiding this comment.
It seems like some texts after to app got deleted.
There was a problem hiding this comment.
Updated in next push
|
@gpucibot merge |
Defines the C API, C++ API, C Unit tests and C++ unit tests for both SG and MG betweenness centrality.
Closes #2642
Closes #2643
Closes #2644
Closes #2646