[REVIEW] Add missing entries in update-version.sh
#2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
improvement
raydouglass
reviewed
Sep 30, 2022
ci/release/update-version.sh
Outdated
| @@ -60,6 +60,8 @@ for FILE in conda/environments/*.yml; do | |||
| sed_runner "s/rmm=${CURRENT_SHORT_TAG}/rmm=${NEXT_SHORT_TAG}/g" ${FILE}; | |||
| sed_runner "s/libraft-headers=${CURRENT_SHORT_TAG}/libraft-headers=${NEXT_SHORT_TAG}/g" ${FILE}; | |||
| sed_runner "s/pyraft=${CURRENT_SHORT_TAG}/pyraft=${NEXT_SHORT_TAG}/g" ${FILE}; | |||
| sed_runner "s/raft-dask=${CURRENT_SHORT_TAG}/libraft-headers=${NEXT_SHORT_TAG}/g" ${FILE}; | |||
There was a problem hiding this comment.
Are you intentionally rewriting raft-dask to libraft-headers or is that a copy-paste error?
There was a problem hiding this comment.
Thanks for the catch, it was a copy-paste error.
galipremsagar
commented
Sep 30, 2022
raydouglass
approved these changes
Sep 30, 2022
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 10, 2022
This PR fixes some missing entries that we not updated in yml files. This wouldn't be necessary for next release as that will be taken care by: #2763 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Brad Rees (https://github.com/BradReesWork) - Jake Awe (https://github.com/AyodeAwe) URL: #2764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
raft-dask&pylibrafttoupdate-version.sh