Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PG allow get_vertex_data to accept single type or id #2698

Merged
merged 2 commits into from
Sep 22, 2022
Merged

PG allow get_vertex_data to accept single type or id #2698

merged 2 commits into from
Sep 22, 2022

Conversation

eriknw
Copy link
Contributor

@eriknw eriknw commented Sep 14, 2022 •
edited
Loading

Closes #2692.

Currently SG only. MG version coming shortly! MG version done.

@eriknw
PG allow get_vertex_data to accept single type or id
fe1104c 
Closes rapidsai#2692.

Currently SG only.  MG version coming shortly!
@eriknw eriknw requested a review from a team as a code owner September 14, 2022 05:15
@eriknw eriknw marked this pull request as draft September 14, 2022 05:16
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022 •
edited
Loading

Codecov Report

Base: 60.11% // Head: 60.08% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (2beddc5) compared to base (4657c68).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-22.10    #2698      +/-   ##
================================================
- Coverage         60.11%   60.08%   -0.03%     
================================================
  Files               112      112              
  Lines              6150     6166      +16     
================================================
+ Hits               3697     3705       +8     
- Misses             2453     2461       +8
Impacted Files Coverage Δ
...ugraph/cugraph/dask/structure/mg_property_graph.py 15.55% <0.00%> (-0.36%) ⬇️
python/cugraph/cugraph/structure/property_graph.py 97.22% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eriknw eriknw marked this pull request as ready for review September 14, 2022 17:59
rlratzel
rlratzel approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a question about a few old FIXMEs which need not hold up approval.

python/cugraph/cugraph/dask/structure/mg_property_graph.py Show resolved Hide resolved
@alexbarghi-nv alexbarghi-nv added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Sep 21, 2022
@alexbarghi-nv alexbarghi-nv modified the milestones: 22.12, 22.10 Sep 21, 2022
@rlratzel
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit be97503 into rapidsai:branch-22.10 Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

Assignees

@eriknw eriknw

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
22.10
Development

Successfully merging this pull request may close these issues.

[FEA] Property Graph get_vertex_data accept int
4 participants
@eriknw @codecov-commenter @rlratzel @alexbarghi-nv