-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renumber PG to be contiguous per type #2697
Conversation
See rapidsai#2627 Currently only SG as we hammer out the API and behavior.
Codecov ReportBase: 60.11% // Head: 60.07% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #2697 +/- ##
================================================
- Coverage 60.11% 60.07% -0.04%
================================================
Files 112 111 -1
Lines 6150 6184 +34
================================================
+ Hits 3697 3715 +18
- Misses 2453 2469 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Either is fine. I prefer inclusive.
I think we dont need it for DGL usecases .
Yup. One vertex id for now for our storage. |
Great, thanks @VibhuJawa. This is ready for review.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@gpucibot merge |
Closes #2627 and CC @VibhuJawa
Currently only SG as we hammer out the API and behavior.
This returns a dataframe with start and stop for each type. Should stop be inclusive or exclusive?
How should we handle vertex ids that only exist in edge data? Should we raise (for now) if this condition exists? I think we can handle this without too much difficulty, but it will take more work.
Since we number edge data, I think edge IDs will often be added in a way that is already contiguous per type. We could keep track of this to avoid unnecessary computation.
Also, I want to confirm that we cannot have multiple rows for a single vertex ID, right? I think we settled on this. Multiple rows with the same ID would cause a problem with the current implementation--it currently gives each row a unique ID.