Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fix to the MG PyG Test to Account for Current Sampling Behavior #2666

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Small fix to the MG PyG Test to Account for Current Sampling Behavior #2666

merged 2 commits into from
Sep 9, 2022

Conversation

alexbarghi-nv
Copy link
Member

This PR will correct an error that shows up occasionally in the MG tests, especially when running on an odd number of GPUs. This error is related to issue #2665 and resolves it temporarily while the C++ team works on a permanent fix.

@alexbarghi-nv alexbarghi-nv self-assigned this Sep 7, 2022
@alexbarghi-nv alexbarghi-nv added python non-breaking Non-breaking change labels Sep 7, 2022
@alexbarghi-nv alexbarghi-nv added this to the 22.10 milestone Sep 7, 2022
@alexbarghi-nv alexbarghi-nv added multi-GPU improvement Improvement / enhancement to an existing function and removed multi-GPU labels Sep 7, 2022
@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review September 7, 2022 04:47
@alexbarghi-nv alexbarghi-nv requested a review from a team as a code owner September 7, 2022 04:47
@alexbarghi-nv
Copy link
Member Author

rerun tests

1 similar comment
@alexbarghi-nv
Copy link
Member Author

rerun tests

rlratzel
rlratzel approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for filing issue #2665

@rlratzel
Copy link
Contributor

rlratzel commented Sep 9, 2022

rerun tests

Latest failure was a CI timeout while building C++ tests, which should be unrelated to these changes.

@alexbarghi-nv
Copy link
Member Author

rerun tests

Latest failure was a CI timeout while building C++ tests, which should be unrelated to these changes.

They've failed a few times now, each time due to a timeout on ARM. I've seen this issue on other PRs as well. Might be good to find a resolution at some point.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@808ac58). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-22.10    #2666   +/-   ##
===============================================
  Coverage                ?   60.11%           
===============================================
  Files                   ?      112           
  Lines                   ?     6150           
  Branches                ?        0           
===============================================
  Hits                    ?     3697           
  Misses                  ?     2453           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rlratzel
Copy link
Contributor

rlratzel commented Sep 9, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit aabda42 into rapidsai:branch-22.10 Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

Assignees

@alexbarghi-nv alexbarghi-nv

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
22.10
Development

Successfully merging this pull request may close these issues.
3 participants
@alexbarghi-nv @rlratzel @codecov-commenter