Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GaaS sources, tests, docs, scripts from the rapidsai/GaaS repo to the cugraph repo #2661

Merged

Conversation

rlratzel
Copy link
Contributor

@rlratzel rlratzel commented Sep 2, 2022

closes #2652

Note to reviewers:

The code here is based on the latest 22.10 GaaS sources which include this last PR to GaaS, and has only been changed to update names ("gaas" -> "cugraph_service") and pass style checks, but the diffs will obviously show everything as new content.

In other words, don't feel obligated to review anything beyond name changes if you've already reviewed the GaaS sources.

Future changes that update functionality related to this move will be done in separate PRs so the diff can clearly show what's being changed.

This is the initial PR which only moves source files and changes names in sources, docs, directories, etc. The unit tests were run (SG and MG) after the name change and they all pass.

One or more followup PRs will be open to add appropriate support for CI (ie. no MG tests run by default, limit to handler tests to simplify automating server subprocesses if necessary, etc.).

The entire GaaS repo is now under python/cugraph_service as a peer to cugraph and pylibcugraph.

rlratzel and others added 30 commits April 21, 2022 03:19
…for graph management and a sampling algo (node2vec). This also includes test cases and a demo script.
Create initial version of GaaS client, server, tests, and demo
…tion extensions functions to Thrift and client API.
…d tests to use that to determine if the server was ready, updated tests to cover preloaded extensions from the server CLI.
… end-to-end test and not just a unit test for the client API, made changes to allow tests to run without setting PYTHONPATH.
…owing thriftpy2.transport.TTransportError to be raised so users do not need to import thriftpy2 to catch exceptions from GaaS.
…pport for retrieving the entire table if necessary instead of just individual rows.
…dgl_1

Add ability to load graphs server-side using custom functions
… tests to match the corresponding get_graph_vertex_dataframe_*() APIs.

(this uncovered assumptions in the tests about the internal dataframe ordering which are currently non-deterministic, still working on this)
… cudf to numpy (and omit tolist()) for return types. Still need to remove debug prints!
rlratzel and others added 19 commits August 17, 2022 14:18
…mpling

Updates to GaaS for Uniform Neighbor Sampling
…e optional, updated adn added tests accordingly.
…_*_data(). Added MG and SG tests to cover different ID types (exposed after a typo went unchecked). Added MG and SG tests to cover get_graph_*_data(). Minor cleanup and refactorings.
@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 2, 2022
@rlratzel rlratzel self-assigned this Sep 2, 2022
@rlratzel rlratzel requested a review from a team as a code owner September 2, 2022 16:53
@BradReesWork BradReesWork added this to the 22.10 milestone Sep 2, 2022
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 837e0ae into rapidsai:branch-22.10 Sep 2, 2022
@rlratzel rlratzel deleted the branch-22.10-gaas_migration branch September 28, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move GaaS source code to cugraph repo
4 participants