Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce cuGraph Sampling Overhead for PyG #2653

Merged
merged 116 commits into from
Oct 3, 2022
Merged

Reduce cuGraph Sampling Overhead for PyG #2653

merged 116 commits into from
Oct 3, 2022

Conversation

alexbarghi-nv
Copy link
Member

@alexbarghi-nv alexbarghi-nv commented Aug 31, 2022 •
edited by BradReesWork
Loading

VibhuJawa and others added 30 commits June 30, 2022 16:23
@VibhuJawa
Address CuGraphStorage reviews
93f6ff9
@alexbarghi-nv
plc graph creation
71824bd
@alexbarghi-nv
remove useless files
7a31e80
@alexbarghi-nv
fix style
4203728
@alexbarghi-nv
remove whitespace
c25d197
@alexbarghi-nv
add tests
51c2f98
@alexbarghi-nv
remove cufile
05bac91
@alexbarghi-nv
add newlines
31b1715
@alexbarghi-nv
test fixes
1ce7fe3
@VibhuJawa
working ndata,edata with all the updates
17e12fd
@VibhuJawa
fixed style checks
71eae74
@alexbarghi-nv
style
052b635
@alexbarghi-nv
style
3b51278
@alexbarghi-nv
add type checking for weights
5a938eb
@VibhuJawa
Add CuGraphStore tests
12ebf68
@VibhuJawa
Fixed Style
d70e43f
@alexbarghi-nv
add sg bfs, fix arg in mg bfs
739b252
@alexbarghi-nv
remove useless files
e3e1038
@alexbarghi-nv
neighbor sampling using stored plc graph
7d7fad4
@alexbarghi-nv
style
d95fac7
@alexbarghi-nv
style
81dcb07
@VibhuJawa
Added graph_store.py and test_graph_store.py
80b9041
@alexbarghi-nv
stop hanging for mg bfs, sampling
834f8a8
@alexbarghi-nv
style
568cc86
@alexbarghi-nv
cugraph
18b3515
@VibhuJawa
fix pytorch import error
5df2d63
@VibhuJawa
Fix to(device) for cupy
c6d1fbf
@alexbarghi-nv
minor
66aa800
@alexbarghi-nv
remove cufile
3324b81
@alexbarghi-nv
Merge branch 'address_CuGraphStorage' of https://github.com/vibhujawa…
5b795bf 
…/cugraph into cugraph-pyg
@alexbarghi-nv alexbarghi-nv changed the title [skip-ci] Reduce cuGraph Sampling Overhead for PyG Reduce cuGraph Sampling Overhead for PyG Sep 29, 2022
@alexbarghi-nv alexbarghi-nv added feature request New feature or request DO NOT MERGE Hold off on merging; see PR for details and removed Blocked Cannot progress due to external reasons DO NOT MERGE Hold off on merging; see PR for details labels Sep 29, 2022
@alexbarghi-nv
Copy link
Member Author

rerun tests

VibhuJawa
VibhuJawa reviewed Sep 29, 2022
View reviewed changes
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files cugraph_store and link_neighbour_loader look good to me. Will review others when the upstreams PR merge.

python/cugraph/cugraph/gnn/pyg_extensions/data/cugraph_store.py Outdated Show resolved Hide resolved
@BradReesWork BradReesWork added the Blocked Cannot progress due to external reasons label Sep 30, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@94bc5ba). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-22.10    #2653   +/-   ##
===============================================
  Coverage                ?   59.79%           
===============================================
  Files                   ?      111           
  Lines                   ?     6358           
  Branches                ?        0           
===============================================
  Hits                    ?     3802           
  Misses                  ?     2556           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

eriknw added a commit to eriknw/cugraph that referenced this pull request Oct 3, 2022
@eriknw
Mark tests as xfail (needs rapidsai#2653)
a9b6681
@alexbarghi-nv alexbarghi-nv removed the Blocked Cannot progress due to external reasons label Oct 3, 2022
VibhuJawa
VibhuJawa approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rlratzel
rlratzel reviewed Oct 3, 2022
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing jumped out, just a few minor things. If we need to merge this ASAP, these can probably get away with being FIXMEs.

notebooks/gnn/pyg_hetero_mag.ipynb Outdated Show resolved Hide resolved
notebooks/gnn/pyg_hetero_mag.ipynb Outdated Show resolved Hide resolved
python/cugraph/cugraph/gnn/pyg_extensions/data/cugraph_store.py Outdated Show resolved Hide resolved
rlratzel
rlratzel approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rlratzel
Copy link
Contributor

rlratzel commented Oct 3, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6a7ea66 into rapidsai:branch-22.10 Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnke2016 jnke2016 jnke2016 approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

@VibhuJawa VibhuJawa VibhuJawa approved these changes

@rlratzel rlratzel rlratzel approved these changes

Assignees

@alexbarghi-nv alexbarghi-nv

Labels
breaking Breaking change feature request New feature or request
Projects
None yet
Milestone
22.10
Development

Successfully merging this pull request may close these issues.
8 participants
@alexbarghi-nv @codecov-commenter @rlratzel @VibhuJawa @BradReesWork @jnke2016 @ChuckHastings @eriknw