Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coverage for uniform neighbor sampling #2625

Merged
merged 7 commits into from
Sep 19, 2022
Merged

Add coverage for uniform neighbor sampling #2625

merged 7 commits into from
Sep 19, 2022

Conversation

jnke2016
Copy link
Contributor

This PR adds coverage for SG PLC uniform neighborhood sampling

closes #2620

@jnke2016 jnke2016 requested a review from a team as a code owner August 28, 2022 15:12
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 29, 2022
@BradReesWork BradReesWork added this to the 22.10 milestone Aug 29, 2022
@ajschmidt8
Copy link
Member

rerun tests

@jnke2016 jnke2016 requested a review from a team as a code owner August 30, 2022 18:07
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@821571d). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head aaa9121 differs from pull request most recent head 85342b0. Consider uploading reports for the commit 85342b0 to get more accurate results

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-22.10    #2625   +/-   ##
===============================================
  Coverage                ?   60.07%           
===============================================
  Files                   ?      112           
  Lines                   ?     6154           
  Branches                ?        0           
===============================================
  Hits                    ?     3697           
  Misses                  ?     2457           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jnke2016
Copy link
Contributor Author

rerun tests

@jnke2016
Copy link
Contributor Author

jnke2016 commented Sep 2, 2022

rerun tests

@BradReesWork
Copy link
Member

rerun tests

@ajschmidt8
Copy link
Member

Removing ops-codeowners from the required reviews since it doesn't seem there are any file changes that we're responsible for. Feel free to add us back if necessary.

@ajschmidt8 ajschmidt8 removed the request for review from a team September 19, 2022 14:07
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3537690 into rapidsai:branch-22.10 Sep 19, 2022
@jnke2016 jnke2016 deleted the branch-22.10_add-coverage-plc-uniform-neighbor-sample branch September 24, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
22.10
Development

Successfully merging this pull request may close these issues.

[FEA] Add coverage for SG PLC Uniform Neighbor Sampling
5 participants
@jnke2016 @ajschmidt8 @codecov-commenter @BradReesWork @rlratzel