-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleanup #2617
Code cleanup #2617
Conversation
… pointers with raft::device_span in edge_partition_view_t & edge_partition_device_view_t)
…efactor_count_local_edges
…efactor_count_local_edges
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #2617 +/- ##
===============================================
Coverage ? 60.07%
===============================================
Files ? 112
Lines ? 6154
Branches ? 0
===============================================
Hits ? 3697
Misses ? 2457
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…efactor_count_local_edges
…efactor_count_local_edges
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Seunghwa for pointing me to major changes.
@gpucibot merge |
As a pre-requisite to address #2600
edge_partition_device_view_t
raft::device_span
in multiple places ofgraph_view_t
,edge_partition_view_t
, andedge_partition_device_view_t
cugraph::test::to_host
was previously defined, but used only in a subset of C++ tests, updateto_host
to take bothraft::device_span
andrmm::device_uvector
as input arguments and use this (instead of update_host) in most of the C++ tests (except for some legacy sampling tests).Breaking as some functions in
graph_view_t
,edge_partition_view_t
andedge_partition_device_view_t
are updated to returnraft::device_span
instead of a raw pointer (these functions are used only internally AFAIK, but still a breaking change in the public API).