Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #2617

Merged

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Aug 24, 2022

As a pre-requisite to address #2600

  • add utility functions to compute local degrees (for the entire set of majors & a subset of the majors) and the sum of local degrees (for a subset of the majors) to edge_partition_device_view_t
  • Replace raw pointers with raft::device_span in multiple places of graph_view_t, edge_partition_view_t, and edge_partition_device_view_t
  • cugraph::test::to_host was previously defined, but used only in a subset of C++ tests, update to_host to take both raft::device_span and rmm::device_uvector as input arguments and use this (instead of update_host) in most of the C++ tests (except for some legacy sampling tests).

Breaking as some functions in graph_view_t, edge_partition_view_t and edge_partition_device_view_t are updated to return raft::device_span instead of a raw pointer (these functions are used only internally AFAIK, but still a breaking change in the public API).

@seunghwak seunghwak requested a review from a team as a code owner August 24, 2022 20:49
@seunghwak seunghwak self-assigned this Aug 24, 2022
@seunghwak seunghwak added 3 - Ready for Review improvement Improvement / enhancement to an existing function labels Aug 24, 2022
@seunghwak seunghwak added this to the 22.10 milestone Aug 24, 2022
@seunghwak seunghwak added the breaking Breaking change label Aug 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@1f83c6b). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 301f75a differs from pull request most recent head 06f0115. Consider uploading reports for the commit 06f0115 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.10    #2617   +/-   ##
===============================================
  Coverage                ?   60.07%           
===============================================
  Files                   ?      112           
  Lines                   ?     6154           
  Branches                ?        0           
===============================================
  Hits                    ?     3697           
  Misses                  ?     2457           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChuckHastings
Copy link
Collaborator

rerun tests

Copy link
Contributor

@naimnv naimnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Seunghwa for pointing me to major changes.

@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 653cca8 into rapidsai:branch-22.10 Sep 1, 2022
@seunghwak seunghwak deleted the enh_refactor_count_local_edges branch October 20, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants