Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the comms import from cugraph's init file #2402

Merged

Conversation

jnke2016
Copy link
Contributor

A breaking change in 22.06 moved the functionalities of comms to cugraph/dask where it should belong as it is only part of the multi GPU API. However cugraph/__init__.py is still importing the the comms when it shouldn't.

This PR removes the comms import in cugraph/__init__.py

closes #2379
closes #2329

@jnke2016 jnke2016 requested a review from a team as a code owner July 12, 2022 01:56
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #2402 (3c67e42) into branch-22.08 (eae4585) will increase coverage by 0.01%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.08    #2402      +/-   ##
================================================
+ Coverage         60.11%   60.12%   +0.01%     
================================================
  Files               102      102              
  Lines              5155     5154       -1     
================================================
  Hits               3099     3099              
+ Misses             2056     2055       -1     
Impacted Files Coverage Δ
python/cugraph/cugraph/__init__.py 100.00% <ø> (ø)
...ython/cugraph/cugraph/community/ktruss_subgraph.py 88.23% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae4585...3c67e42. Read the comment docs.

@rlratzel rlratzel added bug Something isn't working non-breaking Non-breaking change labels Jul 21, 2022
@rlratzel rlratzel added this to the 22.08 milestone Jul 21, 2022
@rlratzel
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f09c298 into rapidsai:branch-22.08 Jul 21, 2022
@jnke2016 jnke2016 deleted the branch-22.08_remove_comms branch September 24, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QST] Are python e2e benchmarks still being supported? [BUG] issue when importing the comms
3 participants