Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving Centrality notebooks to new structure and updating/testing #2388

Merged
merged 21 commits into from
Jul 8, 2022
Merged

Moving Centrality notebooks to new structure and updating/testing #2388

merged 21 commits into from
Jul 8, 2022

Conversation

acostadon
Copy link
Contributor

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@acostadon acostadon added Epic Tracker for a relatively large body of work that is broken down into stories and issues Notebook non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jul 5, 2022
@rlratzel rlratzel added this to the 22.08 milestone Jul 5, 2022
@rlratzel rlratzel added python and removed Epic Tracker for a relatively large body of work that is broken down into stories and issues labels Jul 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2022

Codecov Report

Merging #2388 (e6df448) into branch-22.08 (775a51d) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head e6df448 differs from pull request most recent head 0505715. Consider uploading reports for the commit 0505715 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.08    #2388      +/-   ##
================================================
+ Coverage         60.11%   60.13%   +0.01%     
================================================
  Files               102      102              
  Lines              5155     5155              
================================================
+ Hits               3099     3100       +1     
+ Misses             2056     2055       -1     
Impacted Files Coverage Δ
...ython/cugraph/cugraph/community/ktruss_subgraph.py 88.23% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 775a51d...0505715. Read the comment docs.

@acostadon acostadon marked this pull request as ready for review July 7, 2022 15:54
@acostadon acostadon requested a review from a team as a code owner July 7, 2022 15:54
Copy link
Member

@BradReesWork BradReesWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • algorithms/README - copyright date is wrong
  • centrality README - make the image a little smaller (use the size tags)
  • for each of the sub-READMEs - you can drop the “RAPIDS notebooks” portion
  • Betweenness notebook - karate image broken
  • Betweenness - might be better to drop the “print top score” function and just use the “sort + head” call that is done next
  • Katz - same as above
  • Katz - the the Numpy version still needed?

@BradReesWork
Copy link
Member

@gpucibot merge

@acostadon
Copy link
Contributor Author

rerun tests

@rapids-bot rapids-bot bot merged commit 3d38d4d into rapidsai:branch-22.08 Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants