Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] Generalize ModuleNotFoundError exception handling to ImportError for Amazon SMS libnuma.so.1 bug #2385

Merged

Conversation

rlratzel
Copy link
Contributor

@rlratzel rlratzel commented Jul 2, 2022

Generalize ModuleNotFoundError exception handling to ImportError for Amazon SMS libnuma.so.1 bug
#2113

This allows cugraph to be imported in a SageMaker environment without having to remove ucx-py

@rlratzel
Copy link
Contributor Author

rlratzel commented Jul 6, 2022

rerun tests

@BradReesWork BradReesWork added this to the 22.08 milestone Jul 6, 2022
@ajschmidt8
Copy link
Member

rerun tests

@rlratzel
Copy link
Contributor Author

rlratzel commented Jul 6, 2022

rerun tests

should now be able to get the latest cudf 22.06.01 which should restrict cuda-python to 11.7.0, which should resolve the recent build failures.

@ajschmidt8
Copy link
Member

rerun tests

@vyasr
Copy link
Contributor

vyasr commented Jul 6, 2022

The builds are still failing, I think because the pylibcugraph builds are pulling a version of rmm from before the hotfix:

    rmm:                     22.06.00a220615-cuda11_py38_g185c18e6_76 rapidsai-nightly            
    librmm:                  22.06.00a220615-cuda11_g185c18e6_76      rapidsai-nightly            

Should these be pulled from rapidsai-nightly at all, or do we stop updating the nightly channel after a version is released? I'm not sure how we should be fixing this, but we want 22.06.01, which is on rapidsai now, but not on rapidsai-nightly

@ajschmidt8
Copy link
Member

rerun tests

@vyasr
Copy link
Contributor

vyasr commented Jul 8, 2022

I now see

11:53:47     rmm:                     22.06.00-py39hbcfe0b2_0             conda-forge     
11:47:28     cudf:                    22.06.00-cuda_11_py39_g5658c5b30c_0 rapidsai        

…nd rmm are installed (likely pulled in from some other dependency).
@rlratzel rlratzel requested a review from a team as a code owner July 11, 2022 20:12
…f cudf and rmm are installed (likely pulled in from some other dependency)."

This reverts commit 77add2d.
…++ library should not need the cuDF python API.
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #2385 (1bae944) into branch-22.06 (38be932) will decrease coverage by 10.07%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           branch-22.06    #2385       +/-   ##
=================================================
- Coverage         70.82%   60.74%   -10.08%     
=================================================
  Files               170      105       -65     
  Lines             11036     5075     -5961     
=================================================
- Hits               7816     3083     -4733     
+ Misses             3220     1992     -1228     
Impacted Files Coverage Δ
python/cugraph/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/cugraph/centrality/__init__.py 100.00% <ø> (ø)
...graph/cugraph/centrality/betweenness_centrality.py 89.65% <ø> (ø)
...on/cugraph/cugraph/centrality/degree_centrality.py 81.81% <ø> (ø)
...graph/cugraph/centrality/eigenvector_centrality.py 93.93% <ø> (ø)
...thon/cugraph/cugraph/centrality/katz_centrality.py 89.79% <ø> (+0.32%) ⬆️
python/cugraph/cugraph/community/egonet.py 97.36% <ø> (ø)
...ython/cugraph/cugraph/community/ktruss_subgraph.py 88.23% <ø> (+2.94%) ⬆️
python/cugraph/cugraph/community/leiden.py 100.00% <ø> (+7.69%) ⬆️
python/cugraph/cugraph/community/louvain.py 100.00% <ø> (+7.69%) ⬆️
... and 140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 467a674...1bae944. Read the comment docs.

@raydouglass raydouglass merged commit 76800bc into rapidsai:branch-22.06 Jul 12, 2022
@rlratzel rlratzel deleted the branch-22.06-handle_missing_libnuma branch September 28, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants