Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW]Add get_node_storage and get_edge_storage to CuGraphStorage #2381

Merged
merged 8 commits into from
Jul 20, 2022
Merged

[REVIEW]Add get_node_storage and get_edge_storage to CuGraphStorage #2381

merged 8 commits into from
Jul 20, 2022

Conversation

VibhuJawa
Copy link
Member

@VibhuJawa VibhuJawa commented Jun 30, 2022 •
edited
Loading

This PR enables rapidsai/dgl#14 by adding the following functions/classes to CuGraphStore:

  1. add_node_data
  2. add_edge_data
  3. get_node_storage
  4. get_edge_storage
  5. CuFeatureStorage

@VibhuJawa VibhuJawa added python improvement Improvement / enhancement to an existing function labels Jul 8, 2022
@VibhuJawa VibhuJawa changed the title Address CuGraphStorage reviews Add get_node_storage and get_edge_storage to CuGraphStorage Jul 8, 2022
@VibhuJawa VibhuJawa marked this pull request as ready for review July 8, 2022 21:56
@VibhuJawa VibhuJawa requested a review from a team as a code owner July 8, 2022 21:56
@VibhuJawa VibhuJawa changed the title Add get_node_storage and get_edge_storage to CuGraphStorage [REVIEW]Add get_node_storage and get_edge_storage to CuGraphStorage Jul 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@808ffa6). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08    #2381   +/-   ##
===============================================
  Coverage                ?   60.38%           
===============================================
  Files                   ?      102           
  Lines                   ?     5245           
  Branches                ?        0           
===============================================
  Hits                    ?     3167           
  Misses                  ?     2078           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 808ffa6...c6d1fbf. Read the comment docs.

@VibhuJawa VibhuJawa mentioned this pull request Jul 19, 2022
Closed
@alexbarghi-nv
Copy link
Member

Could you please add experimental wrappers?

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1ae6133 into rapidsai:branch-22.08 Jul 20, 2022
@VibhuJawa VibhuJawa mentioned this pull request Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangxiaoyunNV wangxiaoyunNV wangxiaoyunNV approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VibhuJawa @codecov-commenter @alexbarghi-nv @BradReesWork @wangxiaoyunNV