Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to PC generator #2356

Merged

Conversation

ChuckHastings
Copy link
Collaborator

@ChuckHastings ChuckHastings commented Jun 15, 2022

With the RAFT changes here: rapidsai/raft#690 we should be able to use the PC generator again. The PC generator is significantly faster.

Closes #2266

@ChuckHastings ChuckHastings requested a review from a team as a code owner June 15, 2022 21:59
@ChuckHastings ChuckHastings self-assigned this Jun 15, 2022
@ChuckHastings ChuckHastings added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 15, 2022
@ChuckHastings ChuckHastings added this to the 22.08 milestone Jun 15, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@95824f8). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08    #2356   +/-   ##
===============================================
  Coverage                ?   60.74%           
===============================================
  Files                   ?      105           
  Lines                   ?     5075           
  Branches                ?        0           
===============================================
  Hits                    ?     3083           
  Misses                  ?     1992           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95824f8...b780a7b. Read the comment docs.

@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b3c8c05 into rapidsai:branch-22.08 Jun 21, 2022
@ChuckHastings ChuckHastings deleted the fix_rmat_pc_generator branch August 4, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Rmat C++ tests fail with RNG PC generator type
4 participants