Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sampling primitive again, fix hypersparse computations #2353

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

ChuckHastings
Copy link
Collaborator

@jnke2016 found a few more issues.

This update changes the hyper sparse computation, passes more of the MG tests.

@ChuckHastings ChuckHastings requested a review from a team as a code owner June 14, 2022 17:40
@ChuckHastings ChuckHastings self-assigned this Jun 14, 2022
@ChuckHastings ChuckHastings added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Jun 14, 2022
@ChuckHastings ChuckHastings added this to the 22.08 milestone Jun 14, 2022
Copy link
Contributor

@jnke2016 jnke2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR and it looks good to me

@ChuckHastings
Copy link
Collaborator Author

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@95824f8). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 78f30a6 differs from pull request most recent head c2f09d9. Consider uploading reports for the commit c2f09d9 to get more accurate results

@@               Coverage Diff               @@
##             branch-22.08    #2353   +/-   ##
===============================================
  Coverage                ?   60.74%           
===============================================
  Files                   ?      105           
  Lines                   ?     5075           
  Branches                ?        0           
===============================================
  Hits                    ?     3083           
  Misses                  ?     1992           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95824f8...c2f09d9. Read the comment docs.

@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cf230f4 into rapidsai:branch-22.08 Jun 21, 2022
@ChuckHastings ChuckHastings deleted the fix_sampling_again branch August 4, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants