Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notebook: Nx Generators & Adding Perf_counter #2341

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Release notebook: Nx Generators & Adding Perf_counter #2341

merged 1 commit into from
Jun 8, 2022

Conversation

oorliu
Copy link
Contributor

@oorliu oorliu commented Jun 6, 2022

There was an issue where some Nx methods return a generator and not a full answer. These functions (WCC, Jaccard, and BFS) were identified and fixed for the purpose of getting more accurate ("apples-to-apples") comparisons against cuGraph methods.

Next, time.time() was replaced with time.perf_counter() to get appropriate interval timings.

@oorliu oorliu requested a review from a team as a code owner June 6, 2022 17:50
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python labels Jun 8, 2022
@rlratzel rlratzel added this to the 22.08 milestone Jun 8, 2022
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 80cc3af into rapidsai:branch-22.08 Jun 8, 2022
@oorliu oorliu deleted the release-nb branch June 8, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants