Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update versions to 22.08 #2332

Merged

Conversation

ChuckHastings
Copy link
Collaborator

Update conda files to upgrade raft versions from 22.06 to 22.08

@ChuckHastings ChuckHastings requested a review from a team as a code owner June 2, 2022 20:36
@ChuckHastings ChuckHastings self-assigned this Jun 2, 2022
@ChuckHastings ChuckHastings added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 2, 2022
@ChuckHastings ChuckHastings added this to the 22.08 milestone Jun 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@4922450). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08    #2332   +/-   ##
===============================================
  Coverage                ?   60.74%           
===============================================
  Files                   ?      105           
  Lines                   ?     5075           
  Branches                ?        0           
===============================================
  Hits                    ?     3083           
  Misses                  ?     1992           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4922450...6dad351. Read the comment docs.

Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChuckHastings, can you add entries for these libraries in the automatic update script below?

I think the script could be generalized a bit to something like the following to make sure it captures all current and future libs. I'll leave this up to your discretion.

sed_runner "s/=${CURRENT_SHORT_TAG}/=${NEXT_SHORT_TAG}/g" ${FILE};
  • for FILE in conda/environments/*.yml; do
    sed_runner "s/libcugraphops=${CURRENT_SHORT_TAG}/libcugraphops=${NEXT_SHORT_TAG}/g" ${FILE};
    sed_runner "s/cudf=${CURRENT_SHORT_TAG}/cudf=${NEXT_SHORT_TAG}/g" ${FILE};
    sed_runner "s/rmm=${CURRENT_SHORT_TAG}/rmm=${NEXT_SHORT_TAG}/g" ${FILE};
    sed_runner "s/dask-cuda=${CURRENT_SHORT_TAG}/dask-cuda=${NEXT_SHORT_TAG}/g" ${FILE};
    sed_runner "s/dask-cudf=${CURRENT_SHORT_TAG}/dask-cudf=${NEXT_SHORT_TAG}/g" ${FILE};
    sed_runner "s/cuxfilter=${CURRENT_SHORT_TAG}/cuxfilter=${NEXT_SHORT_TAG}/g" ${FILE};
    sed_runner "s/ucx-py=.*/ucx-py=${NEXT_UCX_PY_VERSION}/g" ${FILE};
    done

@ChuckHastings
Copy link
Collaborator Author

@ChuckHastings, can you add entries for these libraries in the automatic update script below?

I think the script could be generalized a bit to something like the following to make sure it captures all current and future libs. I'll leave this up to your discretion.

sed_runner "s/=${CURRENT_SHORT_TAG}/=${NEXT_SHORT_TAG}/g" ${FILE};
  • for FILE in conda/environments/*.yml; do
    sed_runner "s/libcugraphops=${CURRENT_SHORT_TAG}/libcugraphops=${NEXT_SHORT_TAG}/g" ${FILE};
    sed_runner "s/cudf=${CURRENT_SHORT_TAG}/cudf=${NEXT_SHORT_TAG}/g" ${FILE};
    sed_runner "s/rmm=${CURRENT_SHORT_TAG}/rmm=${NEXT_SHORT_TAG}/g" ${FILE};
    sed_runner "s/dask-cuda=${CURRENT_SHORT_TAG}/dask-cuda=${NEXT_SHORT_TAG}/g" ${FILE};
    sed_runner "s/dask-cudf=${CURRENT_SHORT_TAG}/dask-cudf=${NEXT_SHORT_TAG}/g" ${FILE};
    sed_runner "s/cuxfilter=${CURRENT_SHORT_TAG}/cuxfilter=${NEXT_SHORT_TAG}/g" ${FILE};
    sed_runner "s/ucx-py=.*/ucx-py=${NEXT_UCX_PY_VERSION}/g" ${FILE};
    done

I added a pair of sed expressions to address those libraries. I get nervous about generalizing too much, although none of our current external dependencies overlap in our versioning convention.

@ChuckHastings
Copy link
Collaborator Author

rerun tests

@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 27fceff into rapidsai:branch-22.08 Jun 6, 2022
@ChuckHastings ChuckHastings deleted the update_conda_environment branch August 4, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants