Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sampling handling of dscr region #2321

Conversation

ChuckHastings
Copy link
Collaborator

Bug was discovered in how the sampling code is looking up DCSR offset.

@ChuckHastings ChuckHastings requested a review from a team as a code owner June 1, 2022 16:09
@ChuckHastings ChuckHastings self-assigned this Jun 1, 2022
@ChuckHastings ChuckHastings added this to the 22.06 milestone Jun 1, 2022
@ChuckHastings ChuckHastings added non-breaking Non-breaking change Fix labels Jun 1, 2022
@ChuckHastings ChuckHastings added bug Something isn't working and removed Fix labels Jun 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

Merging #2321 (0e66741) into branch-22.06 (38be932) will decrease coverage by 8.19%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.06    #2321      +/-   ##
================================================
- Coverage         70.82%   62.63%   -8.20%     
================================================
  Files               170      104      -66     
  Lines             11036     4750    -6286     
================================================
- Hits               7816     2975    -4841     
+ Misses             3220     1775    -1445     
Impacted Files Coverage Δ
python/cugraph/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/cugraph/centrality/__init__.py 100.00% <ø> (ø)
...graph/cugraph/centrality/betweenness_centrality.py 89.65% <ø> (ø)
...on/cugraph/cugraph/centrality/degree_centrality.py 81.81% <ø> (ø)
...thon/cugraph/cugraph/centrality/katz_centrality.py 89.79% <ø> (+0.32%) ⬆️
python/cugraph/cugraph/community/egonet.py 97.36% <ø> (ø)
...ython/cugraph/cugraph/community/ktruss_subgraph.py 88.23% <ø> (+2.94%) ⬆️
python/cugraph/cugraph/community/leiden.py 100.00% <ø> (+7.69%) ⬆️
python/cugraph/cugraph/community/louvain.py 100.00% <ø> (+7.69%) ⬆️
python/cugraph/cugraph/community/triangle_count.py 100.00% <ø> (+11.11%) ⬆️
... and 139 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 305392d...0e66741. Read the comment docs.

@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5d147ef into rapidsai:branch-22.06 Jun 1, 2022
@ChuckHastings ChuckHastings deleted the fix_sampling_hypersparse_issue branch August 4, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants