Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Louvain to the C API #2292

Merged
merged 2 commits into from
May 23, 2022

Conversation

ChuckHastings
Copy link
Collaborator

This PR adds Louvain to the C API. This PR is a full implementation including:

  • C API definition
  • C API implementation calling the C++ version of Louvain
  • SG and MG unit tests exercising the Louvain implementation
  • A small documentation update to triangle counting that was discovered in the final review of the triangle counting C API PR

@ChuckHastings ChuckHastings requested review from a team as code owners May 19, 2022 22:46
@ChuckHastings ChuckHastings self-assigned this May 19, 2022
@ChuckHastings ChuckHastings added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 19, 2022
@ChuckHastings ChuckHastings added this to the 22.06 milestone May 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #2292 (f7b3e67) into branch-22.06 (046cbd2) will decrease coverage by 0.17%.
The diff coverage is 44.66%.

❗ Current head f7b3e67 differs from pull request most recent head 5cd323d. Consider uploading reports for the commit 5cd323d to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06    #2292      +/-   ##
================================================
- Coverage         63.97%   63.80%   -0.18%     
================================================
  Files               100      100              
  Lines              4436     4481      +45     
================================================
+ Hits               2838     2859      +21     
- Misses             1598     1622      +24     
Impacted Files Coverage Δ
python/cugraph/cugraph/dask/community/louvain.py 24.24% <0.00%> (-1.57%) ⬇️
python/cugraph/cugraph/dask/link_analysis/hits.py 18.75% <0.00%> (ø)
...aph/cugraph/dask/sampling/neighborhood_sampling.py 0.00% <0.00%> (ø)
python/cugraph/cugraph/dask/traversal/bfs.py 14.75% <0.00%> (-1.92%) ⬇️
python/cugraph/cugraph/dask/traversal/sssp.py 21.42% <0.00%> (-1.08%) ⬇️
python/cugraph/cugraph/structure/number_map.py 65.83% <6.66%> (-0.96%) ⬇️
...ure/graph_implementation/simpleDistributedGraph.py 23.02% <42.85%> (+0.42%) ⬆️
python/cugraph/cugraph/traversal/bfs.py 78.87% <58.33%> (-7.13%) ⬇️
...ython/cugraph/cugraph/community/ktruss_subgraph.py 88.23% <100.00%> (+2.94%) ⬆️
python/cugraph/cugraph/community/leiden.py 100.00% <100.00%> (+7.69%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 046cbd2...5cd323d. Read the comment docs.

Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, when can we delete the legacy Louvain? After python updates?

@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c837aaa into rapidsai:branch-22.06 May 23, 2022
@ChuckHastings ChuckHastings deleted the fea_add_louvain_c_api branch August 4, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants