Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MG BFS through C API #2291

Conversation

ChuckHastings
Copy link
Collaborator

@alexbarghi-nv found some issues testing BFS for MG through the C API. Essential problem is that the C API needs to shuffle the source vertices across the GPUs.

Did the following:

  • Add Alex B's mg_bfs_test
  • Add missing mg_sssp_test
  • Add shuffle of vertex ids for MG in bfs
  • Fix sizing of array in sssp

@ChuckHastings ChuckHastings requested review from a team as code owners May 19, 2022 19:59
@ChuckHastings ChuckHastings self-assigned this May 19, 2022
@ChuckHastings ChuckHastings added 3 - Ready for Review bug Something isn't working non-breaking Non-breaking change labels May 19, 2022
@ChuckHastings ChuckHastings added this to the 22.06 milestone May 19, 2022
@ChuckHastings ChuckHastings added improvement Improvement / enhancement to an existing function and removed improvement Improvement / enhancement to an existing function labels May 19, 2022
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexbarghi-nv
Copy link
Member

Reviewing now...

Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified everything is working now

@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit aece453 into rapidsai:branch-22.06 May 20, 2022
@ChuckHastings ChuckHastings deleted the fix_add_shuffle_to_capi_algorithms branch August 4, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants