Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cudf moved the default_hash into the cudf::detail namespace #2244

Merged

Conversation

ChuckHastings
Copy link
Collaborator

@ChuckHastings ChuckHastings commented Apr 25, 2022

Updated as part of rapidsai/cudf#10462

Update namespace for default_hash.

Also update a python call that was changed in cudf.

@ChuckHastings ChuckHastings requested a review from a team as a code owner April 25, 2022 17:46
@ChuckHastings ChuckHastings self-assigned this Apr 25, 2022
@ChuckHastings ChuckHastings added this to the 22.06 milestone Apr 25, 2022
@ChuckHastings ChuckHastings added non-breaking Non-breaking change Fix bug Something isn't working and removed Fix labels Apr 25, 2022
@ChuckHastings ChuckHastings requested a review from a team as a code owner April 25, 2022 21:20
@codecov-commenter
Copy link

Codecov Report

Merging #2244 (43e25db) into branch-22.06 (38be932) will increase coverage by 0.43%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.06    #2244      +/-   ##
================================================
+ Coverage         70.82%   71.25%   +0.43%     
================================================
  Files               170      171       +1     
  Lines             11036    11167     +131     
================================================
+ Hits               7816     7957     +141     
+ Misses             3220     3210      -10     
Impacted Files Coverage Δ
python/cugraph/cugraph/centrality/__init__.py 100.00% <ø> (ø)
...thon/cugraph/cugraph/centrality/katz_centrality.py 87.75% <ø> (-1.72%) ⬇️
python/cugraph/cugraph/dask/common/part_utils.py 19.23% <ø> (-0.94%) ⬇️
python/cugraph/cugraph/gnn/graph_store.py 82.60% <ø> (+11.77%) ⬆️
python/cugraph/cugraph/structure/hypergraph.py 90.00% <ø> (ø)
python/cugraph/cugraph/tests/dask/test_mg_bfs.py 0.00% <ø> (ø)
python/cugraph/cugraph/tests/dask/test_mg_comms.py 0.00% <ø> (ø)
...cugraph/cugraph/tests/dask/test_mg_connectivity.py 0.00% <ø> (ø)
...ython/cugraph/cugraph/tests/dask/test_mg_degree.py 0.00% <ø> (ø)
python/cugraph/cugraph/tests/dask/test_mg_hits.py 0.00% <ø> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c4cd18...43e25db. Read the comment docs.

@codecov-commenter
Copy link

Codecov Report

Merging #2244 (43e25db) into branch-22.06 (38be932) will increase coverage by 0.47%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.06    #2244      +/-   ##
================================================
+ Coverage         70.82%   71.29%   +0.47%     
================================================
  Files               170      171       +1     
  Lines             11036    11167     +131     
================================================
+ Hits               7816     7962     +146     
+ Misses             3220     3205      -15     
Impacted Files Coverage Δ
python/cugraph/cugraph/centrality/__init__.py 100.00% <ø> (ø)
...thon/cugraph/cugraph/centrality/katz_centrality.py 87.75% <ø> (-1.72%) ⬇️
python/cugraph/cugraph/dask/common/part_utils.py 19.23% <ø> (-0.94%) ⬇️
python/cugraph/cugraph/gnn/graph_store.py 82.60% <ø> (+11.77%) ⬆️
python/cugraph/cugraph/structure/hypergraph.py 90.00% <ø> (ø)
python/cugraph/cugraph/tests/dask/test_mg_bfs.py 0.00% <ø> (ø)
python/cugraph/cugraph/tests/dask/test_mg_comms.py 0.00% <ø> (ø)
...cugraph/cugraph/tests/dask/test_mg_connectivity.py 0.00% <ø> (ø)
...ython/cugraph/cugraph/tests/dask/test_mg_degree.py 0.00% <ø> (ø)
python/cugraph/cugraph/tests/dask/test_mg_hits.py 0.00% <ø> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c4cd18...43e25db. Read the comment docs.

1 similar comment
@codecov-commenter
Copy link

Codecov Report

Merging #2244 (43e25db) into branch-22.06 (38be932) will increase coverage by 0.47%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.06    #2244      +/-   ##
================================================
+ Coverage         70.82%   71.29%   +0.47%     
================================================
  Files               170      171       +1     
  Lines             11036    11167     +131     
================================================
+ Hits               7816     7962     +146     
+ Misses             3220     3205      -15     
Impacted Files Coverage Δ
python/cugraph/cugraph/centrality/__init__.py 100.00% <ø> (ø)
...thon/cugraph/cugraph/centrality/katz_centrality.py 87.75% <ø> (-1.72%) ⬇️
python/cugraph/cugraph/dask/common/part_utils.py 19.23% <ø> (-0.94%) ⬇️
python/cugraph/cugraph/gnn/graph_store.py 82.60% <ø> (+11.77%) ⬆️
python/cugraph/cugraph/structure/hypergraph.py 90.00% <ø> (ø)
python/cugraph/cugraph/tests/dask/test_mg_bfs.py 0.00% <ø> (ø)
python/cugraph/cugraph/tests/dask/test_mg_comms.py 0.00% <ø> (ø)
...cugraph/cugraph/tests/dask/test_mg_connectivity.py 0.00% <ø> (ø)
...ython/cugraph/cugraph/tests/dask/test_mg_degree.py 0.00% <ø> (ø)
python/cugraph/cugraph/tests/dask/test_mg_hits.py 0.00% <ø> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c4cd18...43e25db. Read the comment docs.

@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 47ef819 into rapidsai:branch-22.06 Apr 26, 2022
@ChuckHastings ChuckHastings deleted the fix_cudf_default_hash_change branch August 4, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants