Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves pylibcugraph APIS from 22.04 and earlier out of experimental namespace #2232

Merged

Conversation

betochimas
Copy link
Contributor

This PR addresses and closes #2202. Specifically, this PR does the following:

  • Adds current experimental pylibcugraph APIs outside of experimental namespace, without removing the ones inside that namespace (duplicating in a sense)
  • The ones promoted outside have no warning wrappers attached
  • The original APIs have a different warning applied to them, stating that their version will be removed within a few releases, leaving the promoted ones intact

@betochimas betochimas requested a review from a team as a code owner April 18, 2022 22:19
@betochimas betochimas added 3 - Ready for Review non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Apr 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022

Codecov Report

Merging #2232 (70b7a82) into branch-22.06 (da07cad) will increase coverage by 0.25%.
The diff coverage is 95.91%.

@@               Coverage Diff                @@
##           branch-22.06    #2232      +/-   ##
================================================
+ Coverage         71.00%   71.26%   +0.25%     
================================================
  Files               170      170              
  Lines             11099    11117      +18     
================================================
+ Hits               7881     7922      +41     
+ Misses             3218     3195      -23     
Impacted Files Coverage Δ
...n/pylibcugraph/pylibcugraph/utilities/api_tools.py 95.52% <93.54%> (-4.48%) ⬇️
python/pylibcugraph/pylibcugraph/__init__.py 100.00% <100.00%> (ø)
...pylibcugraph/pylibcugraph/experimental/__init__.py 100.00% <100.00%> (ø)
python/cugraph/cugraph/tests/dask/test_mg_bfs.py 0.00% <0.00%> (ø)
python/cugraph/cugraph/tests/dask/test_mg_hits.py 0.00% <0.00%> (ø)
python/cugraph/cugraph/tests/dask/test_mg_sssp.py 0.00% <0.00%> (ø)
python/cugraph/cugraph/tests/dask/test_mg_comms.py 0.00% <0.00%> (ø)
...thon/cugraph/cugraph/tests/dask/test_mg_louvain.py 0.00% <0.00%> (ø)
...thon/cugraph/cugraph/tests/dask/test_mg_utility.py 0.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da07cad...70b7a82. Read the comment docs.

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, but there's a couple of things left:

  • All of the tests, notebooks, and other source code that imports these objects from pylibcugraph.experimental has to be updated to import them from the new permanent namespace (should be a metter of just dropping a .experimental from an import statement). Here and here are two examples.
  • The long and ugly EXPERIMENTAL_ prefixes should be removed from the promoted APIs and all code updated (FYI those prefixes were used for discouraging users from importing these objects directly from the module they were defined in instead of from the experimental namespace, but now that they're promoted, that's not necessary).

@betochimas
Copy link
Contributor Author

rerun tests

Merging in fix with recent cugraph build failure
@betochimas
Copy link
Contributor Author

rerun tests

@BradReesWork BradReesWork added this to the 22.06 milestone Apr 28, 2022
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 728950e into rapidsai:branch-22.06 Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Move pylibcugraph APIs from 22.04 and earlier out of experimental
4 participants