-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves pylibcugraph APIS from 22.04 and earlier out of experimental
namespace
#2232
Moves pylibcugraph APIS from 22.04 and earlier out of experimental
namespace
#2232
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #2232 +/- ##
================================================
+ Coverage 71.00% 71.26% +0.25%
================================================
Files 170 170
Lines 11099 11117 +18
================================================
+ Hits 7881 7922 +41
+ Misses 3218 3195 -23
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, but there's a couple of things left:
- All of the tests, notebooks, and other source code that imports these objects from
pylibcugraph.experimental
has to be updated to import them from the new permanent namespace (should be a metter of just dropping a.experimental
from an import statement). Here and here are two examples. - The long and ugly
EXPERIMENTAL_
prefixes should be removed from the promoted APIs and all code updated (FYI those prefixes were used for discouraging users from importing these objects directly from the module they were defined in instead of from the experimental namespace, but now that they're promoted, that's not necessary).
rerun tests |
Merging in fix with recent cugraph build failure
rerun tests |
@gpucibot merge |
This PR addresses and closes #2202. Specifically, this PR does the following: