Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for reading edge and vertex data from single input in PG, implementation to follow. #2154

Merged
merged 3 commits into from
Sep 30, 2022
Merged

Add tests for reading edge and vertex data from single input in PG, implementation to follow. #2154

merged 3 commits into from
Sep 30, 2022

Conversation

rlratzel
Copy link
Contributor

@rlratzel rlratzel commented Mar 23, 2022 •
edited
Loading

rapidsai/cugraph-pg#7 describes additional use cases that PropertyGraph needs to support. This PR adds tests to ensure those are supported.

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 23, 2022
@rlratzel rlratzel added this to the 22.04 milestone Mar 23, 2022
@rlratzel rlratzel self-assigned this Mar 23, 2022
@BradReesWork BradReesWork modified the milestones: 22.04, 22.06 Mar 28, 2022
@BradReesWork BradReesWork changed the base branch from branch-22.04 to branch-22.06 March 28, 2022 17:38
@rlratzel rlratzel added the python label Apr 7, 2022
@rlratzel rlratzel changed the title Updates to PropertyGraph tests to ensure requirements in cugraph issue #2109 can be met Add support for reading edge and vertex data from single input May 5, 2022
@rlratzel rlratzel changed the base branch from branch-22.06 to branch-22.08 May 25, 2022 15:14
@rlratzel rlratzel modified the milestones: 22.06, 22.08 May 25, 2022
@rlratzel rlratzel modified the milestones: 22.08, 22.10 Jul 14, 2022
@rlratzel rlratzel changed the base branch from branch-22.08 to branch-22.10 July 29, 2022 17:00
@rlratzel rlratzel changed the title Add support for reading edge and vertex data from single input Add tests for reading edge and vertex data from single input in PG, implementation to follow. Sep 30, 2022
@rlratzel rlratzel marked this pull request as ready for review September 30, 2022 14:30
@rlratzel rlratzel requested a review from a team as a code owner September 30, 2022 14:30
@rapidsai rapidsai deleted a comment from github-actions bot Sep 30, 2022
alexbarghi-nv
alexbarghi-nv approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

VibhuJawa
VibhuJawa approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a5b542e into rapidsai:branch-22.10 Sep 30, 2022
@rlratzel rlratzel deleted the branch-22.04-new_propgraph_tests branch September 28, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbarghi-nv alexbarghi-nv alexbarghi-nv approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

@VibhuJawa VibhuJawa VibhuJawa approved these changes

@eriknw eriknw Awaiting requested review from eriknw

Assignees

@rlratzel rlratzel

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
22.10
Development

Successfully merging this pull request may close these issues.
4 participants
@rlratzel @BradReesWork @VibhuJawa @alexbarghi-nv