Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Pin gtest/gmock to 1.10.0 in dev envs #2127

Merged
merged 2 commits into from
Mar 22, 2022
Merged

[FIX] Pin gtest/gmock to 1.10.0 in dev envs #2127

merged 2 commits into from
Mar 22, 2022

Conversation

trxcllnt
Copy link
Collaborator

No description provided.

@trxcllnt trxcllnt requested a review from a team as a code owner March 18, 2022 19:02
@trxcllnt trxcllnt added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 18, 2022
@robertmaynard
Copy link
Contributor

Context:
rapids-cmake searches for the EXACT GTest version and so we need to pin the GTest version.

@BradReesWork BradReesWork added this to the 22.04 milestone Mar 18, 2022
@BradReesWork
Copy link
Member

rerun tests

@rlratzel
Copy link
Contributor

Context: rapids-cmake searches for the EXACT GTest version and so we need to pin the GTest version.

Thank you for providing the context.

@ajschmidt8
Copy link
Member

@trxcllnt, can you merge the latest changes into your PR here? I think the build issue you're experiencing that's shown below might be resolved by #2125.

image

@seunghwak
Copy link
Contributor

seunghwak commented Mar 22, 2022 •
edited
Loading

Pulling this PR was necessary to avoid puzzling undefined reference to ... errors in my development environment. One more reason to merge this PR.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5255aad into rapidsai:branch-22.04 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@rlratzel rlratzel rlratzel approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
22.04
Development

Successfully merging this pull request may close these issues.
6 participants
@trxcllnt @robertmaynard @BradReesWork @rlratzel @ajschmidt8 @seunghwak