Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nx compatibility based on making Graph subclass and calling Cugraph algos #2099

Merged
merged 61 commits into from
Mar 30, 2022
Merged

Nx compatibility based on making Graph subclass and calling Cugraph algos #2099

merged 61 commits into from
Mar 30, 2022

Conversation

acostadon
Copy link
Contributor

@acostadon acostadon commented Mar 1, 2022 •
edited
Loading

Code to inherit all of networkx graph then call cugraph pagerank with just an import change.
This was originally going to do bfs first but pargerank was considered a more useful first algorithm.

@acostadon
Created initial list of simple Graph creation tests for nx compatibility
c02bfde
@acostadon
Merge remote-tracking branch 'upstream/branch-22.04' into nxCompat
35c2878
@acostadon
cleaned up flake8, copywrite and removed important warning
58beab4
@acostadon
Added call to bfs in test case
33f83b8
@acostadon
adding initial nx code to development branch
9d39bb7
@acostadon
Merge remote-tracking branch 'upstream/branch-22.04' into branch-22.0…
2012edd 
…4-init-compat-code
@acostadon
Adding more Graph code
f52c560
@acostadon
Merge remote-tracking branch 'upstream/branch-22.04' into branch-22.0…
57d214d 
…4-init-compat-code
@acostadon
Added some adjacency code to Graph and started testing it
0ea4ee9
@acostadon
Merge remote-tracking branch 'upstream/branch-22.04' into branch-22.0…
fa15f29 
…4-init-compat-code
@acostadon
Merge remote-tracking branch 'upstream/branch-22.04' into branch-22.0…
6092bc1 
…4-init-compat-code
@acostadon
adding more nx methods to graph
b306981
@acostadon
Adding tests as Graph gets implemented
56f0ff8
@acostadon
Added changes for new Property Graph parameter names
aef4d9a
@acostadon
Merge remote-tracking branch 'upstream/branch-22.04' into branch-22.0…
8257f8c 
…4-init-compat-code
@acostadon
making weights work in Graph testing with algorithms
f20e536
@acostadon
Merge remote-tracking branch 'upstream/branch-22.04' into branch-22.0…
f61d615 
…4-init-compat-code
@acostadon
Added weighted load and ran bfs
29c892d
@acostadon
Merge remote-tracking branch 'upstream/branch-22.04' into branch-22.0…
6511f84 
…4-init-compat-code
@acostadon
Merge remote-tracking branch 'upstream/branch-22.04' into branch-22.0…
3ddeb91 
…4-init-compat-code
@acostadon
Added subscripting code and NotImplementedError
0ed3f7b
@acostadon
inheriting everything from networkx graph and calling cugraph bfs
6d7dc2f
@acostadon
more files to call cugraph bfs from networkx graph
45ef5d1
@acostadon acostadon added DO NOT MERGE Hold off on merging; see PR for details Epic Tracker for a relatively large body of work that is broken down into stories and issues non-breaking Non-breaking change python labels Mar 1, 2022
@BradReesWork BradReesWork self-requested a review March 29, 2022 15:36
rlratzel
rlratzel reviewed Mar 30, 2022
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I had just one minor suggestion.

python/cugraph/cugraph/tests/test_compat_pr.py


@pytest.fixture(scope="module", params=fixture_params)
def input_combo(request):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixture isn't used by any tests so you could just combine it with input_expected_output()

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 04ca362 into rapidsai:branch-22.04 Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnke2016 jnke2016 jnke2016 left review comments

@rlratzel rlratzel rlratzel left review comments

@BradReesWork BradReesWork BradReesWork approved these changes

Assignees

@acostadon acostadon

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
22.04
Development

Successfully merging this pull request may close these issues.
5 participants
@acostadon @rlratzel @codecov-commenter @BradReesWork @jnke2016